refactor

Author: Byron

git-diff/tests/tree/mod.rs renamed to git-diff/tests/visit/mod.rs

@@ -1,8 +1,11 @@
 mod with_tree {
+    use crate::hex_to_id;
+    use git_diff::visit::recorder;
     use git_odb::{pack, Locate};
+
     const FIRST_COMMIT: &str = "055df97e18cd537da3cb16bcbdf1733fdcdfb430";
 
-    fn diff_at(commit_id: &str) -> crate::Result {
+    fn diff_at(commit_id: &str) -> crate::Result<recorder::Changes> {
         let db = git_odb::linked::Db::at(
             test_tools::scripted_fixture_repo_read_only("make_diff_repo.sh")?
                 .join(".git")
@@ -41,18 +44,27 @@ mod with_tree {
                 .and_then(|tree| tree.into_tree())
         };
 
+        let mut recorder = git_diff::visit::Recorder::default();
         git_diff::visit::Changes::from(previous_tree.as_ref()).to_obtain_tree(
             &main_tree,
             &mut git_diff::visit::State::default(),
             |_oid, _buf| todo!("Actual lookup in db"),
-            &mut git_diff::visit::Recorder::default(),
+            &mut recorder,
         )?;
-        Ok(())
+        Ok(recorder.records)
     }
     #[test]
     #[should_panic]
     fn file_added() {
-        diff_at(FIRST_COMMIT).unwrap();
+        // :000000 100644 0000000000000000000000000000000000000000 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 A      f
+        assert_eq!(
+            diff_at(FIRST_COMMIT).unwrap(),
+            vec![recorder::Change::Addition {
+                mode: git_object::tree::Mode::Tree,
+                oid: hex_to_id("e69de29bb2d1d6434b8b29ae775ad8c2e48c5391"),
+                path: "f".into()
+            }]
+        );
         todo!("detect an added file in the root tree")
     }
 }

git-object/tests/borrowed/commit.rs renamed to git-object/tests/immutable/commit.rs

@@ -1,5 +1,5 @@
 mod method {
-    use crate::{borrowed::fixture_bytes, hex_to_id};
+    use crate::{hex_to_id, immutable::fixture_bytes};
     use git_object::immutable::Commit;
     use pretty_assertions::assert_eq;
 
@@ -14,8 +14,8 @@ mod method {
 }
 
 mod from_bytes {
-    use crate::borrowed::linus_signature;
-    use crate::{borrowed::fixture_bytes, borrowed::signature};
+    use crate::immutable::linus_signature;
+    use crate::{immutable::fixture_bytes, immutable::signature};
     use git_object::{bstr::ByteSlice, immutable::Commit};
     use smallvec::SmallVec;
 

git-object/tests/borrowed/mod.rs renamed to git-object/tests/immutable/mod.rs

@@ -5,7 +5,7 @@ use git_object::{
 };
 
 mod method {
-    use crate::{borrowed::fixture_bytes, hex_to_id};
+    use crate::{hex_to_id, immutable::fixture_bytes};
     use git_object::immutable::Tag;
     use pretty_assertions::assert_eq;
 
@@ -20,7 +20,7 @@ mod method {
 }
 
 mod from_bytes {
-    use crate::{borrowed::fixture_bytes, borrowed::signature, borrowed::tag::tag_fixture};
+    use crate::{immutable::fixture_bytes, immutable::signature, immutable::tag::tag_fixture};
     use git_object::{bstr::ByteSlice, immutable::Tag, Kind};
 
     #[test]

git-object/tests/borrowed/tag.rs renamed to git-object/tests/immutable/tag.rs

@@ -1,5 +1,5 @@
 mod from_bytes {
-    use crate::borrowed::fixture_bytes;
+    use crate::immutable::fixture_bytes;
     use git_object::{
         bstr::ByteSlice,
         immutable::{tree::Entry, Tree},

git-object/tests/borrowed/tree.rs renamed to git-object/tests/immutable/tree.rs

@@ -1,7 +1,7 @@
 use std::path::PathBuf;
 
-mod borrowed;
-mod owned;
+mod immutable;
+mod mutable;
 
 #[cfg(not(windows))]
 fn fixup(v: Vec<u8>) -> Vec<u8> {