Skip to content

Commit 6771838

Browse files
committed
Temporarily keep i686 job failure from canceling armv7 job
`test-32bit` fails in the job for the `i686-unknown-linux-musl` target since changing `-p gix-hashtable` to `-p gix` in the test step because various data structure size assertions fail, which is because some data structures are smaller on 32-bit archictectures than on 64-bit architectures. That is unrelated to the commented problem of environment not being passed into the test environment, which does not happen on `i686-unknown-linux-musl`. But maybe it would happen on `armv7-linux-androideabi`, due to its use of cross. The i686 job, which doesn't require emulation, is faster, and when it fails due to those assertions, it keeps the armv7 job from getting far enough to reveal if it has its own environment-related (or other) failures. This temporarily sets `fail-fast: false` so that the armv7 job can get far enough that we find out.
1 parent bb06629 commit 6771838

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,7 @@ jobs:
208208
cargo: cargo
209209
- target: armv7-linux-androideabi
210210
cargo: cross
211+
fail-fast: false # FIXME: Remove this after testing.
211212

212213
steps:
213214
- uses: actions/checkout@v4

0 commit comments

Comments
 (0)