Thanks clippy

Author: cruessler

gix-path/src/relative_path.rs

@@ -3,7 +3,6 @@ use bstr::BString;
 use bstr::ByteSlice;
 use gix_validate::path::component::Options;
 use std::borrow::Cow;
-use std::u8;
 
 use crate::os_str_into_bstr;
 use crate::try_from_bstr;
@@ -67,7 +66,7 @@ impl<'a, const N: usize> TryFrom<&'a [u8; N]> for &'a RelativePath {
 
     #[inline]
     fn try_from(value: &'a [u8; N]) -> Result<Self, Self::Error> {
-        let path: &std::path::Path = &try_from_byte_slice(value)?;
+        let path: &std::path::Path = try_from_byte_slice(value)?;
 
         let options: Options = Default::default();
 

gix-ref/src/namespace.rs

@@ -22,7 +22,7 @@ impl Namespace {
     ///
     /// The prefix is a relative path with slash-separated path components.
     // TODO: use `RelativePath` type instead (see #1921), or a trait that helps convert into it.
-    pub fn into_namespaced_prefix<'a>(mut self, prefix: &'a RelativePath) -> BString {
+    pub fn into_namespaced_prefix(mut self, prefix: &RelativePath) -> BString {
         self.0.push_str(prefix);
         gix_path::to_unix_separators_on_windows(self.0).into_owned()
     }

gix-ref/src/store/file/loose/iter.rs

@@ -90,7 +90,7 @@ impl file::Store {
     ///
     /// Prefixes are relative paths with slash-separated components.
     // TODO: use `RelativePath` type instead (see #1921), or a trait that helps convert into it.
-    pub fn loose_iter_prefixed<'a>(&self, prefix: &'a RelativePath) -> std::io::Result<LooseThenPacked<'_, '_>> {
+    pub fn loose_iter_prefixed(&self, prefix: &RelativePath) -> std::io::Result<LooseThenPacked<'_, '_>> {
         self.iter_prefixed_packed(prefix, None)
     }
 }

gix-ref/src/store/file/overlay_iter.rs

@@ -207,7 +207,7 @@ impl Platform<'_> {
     ///
     /// Prefixes are relative paths with slash-separated components.
     // TODO: use `RelativePath` type instead (see #1921), or a trait that helps convert into it.
-    pub fn prefixed<'a>(&self, prefix: &'a RelativePath) -> std::io::Result<LooseThenPacked<'_, '_>> {
+    pub fn prefixed(&self, prefix: &RelativePath) -> std::io::Result<LooseThenPacked<'_, '_>> {
         self.store
             .iter_prefixed_packed(prefix, self.packed.as_ref().map(|b| &***b))
     }
@@ -376,12 +376,11 @@ impl file::Store {
     ///
     /// Prefixes are relative paths with slash-separated components.
     // TODO: use `RelativePath` type instead (see #1921), or a trait that helps convert into it.
-    pub fn iter_prefixed_packed<'a, 's, 'p>(
+    pub fn iter_prefixed_packed<'s, 'p>(
         &'s self,
-        prefix: &'a RelativePath,
+        prefix: &RelativePath,
         packed: Option<&'p packed::Buffer>,
     ) -> std::io::Result<LooseThenPacked<'p, 's>> {
-        let prefix = prefix.into();
         match self.namespace.as_ref() {
             None => {
                 let git_dir_info = IterInfo::from_prefix(self.git_dir(), prefix, self.precompose_unicode)?;
@@ -393,7 +392,7 @@ impl file::Store {
             }
             Some(namespace) => {
                 let prefix = namespace.to_owned().into_namespaced_prefix(prefix);
-                let prefix = prefix.as_bstr().try_into().map_err(|err| std::io::Error::other(err))?;
+                let prefix = prefix.as_bstr().try_into().map_err(std::io::Error::other)?;
                 let git_dir_info = IterInfo::from_prefix(self.git_dir(), prefix, self.precompose_unicode)?;
                 let common_dir_info = self
                     .common_dir()