Remove a hack which makes '1979-02-26 18:30:00' special.

Author: Byron

gix-date/src/parse.rs

@@ -145,11 +145,6 @@ pub(crate) mod function {
     ///     *   `2 minutes ago` (October 27, 2023 at 09:58:00 UTC)
     ///     *   `3 hours ago` (October 27, 2023 at 07:00:00 UTC)
     pub fn parse(input: &str, now: Option<SystemTime>) -> Result<Time, Error> {
-        // TODO: actual implementation, this is just to not constantly fail
-        if input == "1979-02-26 18:30:00" {
-            return Ok(Time::new(42, 1800));
-        }
-
         Ok(if let Ok(val) = Date::strptime(SHORT.0, input) {
             let val = val
                 .to_zoned(TimeZone::UTC)

gix-date/tests/time/parse.rs

@@ -3,13 +3,10 @@ use std::time::SystemTime;
 use gix_date::Time;
 
 #[test]
-fn special_time_is_ok_for_now() {
-    assert_eq!(
-        gix_date::parse("1979-02-26 18:30:00", Some(SystemTime::now())).unwrap(),
-        Time {
-            seconds: 42,
-            offset: 1800,
-        }
+fn time_without_offset_is_not_parsed_yet() {
+    assert!(
+        gix_date::parse("1979-02-26 18:30:00", Some(SystemTime::now())).is_err(),
+        "This was a special time with special handling, but it is not  anymore"
     );
 }
 

gix-revision/tests/revision/spec/parse/anchor/at_symbol.rs

@@ -35,7 +35,7 @@ fn reflog_by_entry_for_current_branch() {
 
 #[test]
 fn reflog_by_date_for_current_branch() {
-    let rec = parse("@{1979-02-26 18:30:00}");
+    let rec = parse("@{42 +0030}");
 
     assert!(rec.kind.is_none());
     assert_eq!(rec.find_ref[0], None);
@@ -81,9 +81,9 @@ fn reflog_by_date_with_date_parse_failure() {
 #[test]
 fn reflog_by_date_for_hash_is_invalid() {
     for (spec, full_name) in [
-        ("1234@{1979-02-26 18:30:00}", "1234"),
-        ("abcd-dirty@{1979-02-26 18:30:00}", "abcd-dirty"),
-        ("v1.2.3-0-g1234@{1979-02-26 18:30:00}", "v1.2.3-0-g1234"),
+        ("1234@{42 +0030}", "1234"),
+        ("abcd-dirty@{42 +0030}", "abcd-dirty"),
+        ("v1.2.3-0-g1234@{42 +0030}", "v1.2.3-0-g1234"),
     ] {
         let err = try_parse(spec).unwrap_err();
         assert!(matches!(err, spec::parse::Error::ReflogLookupNeedsRefName {name} if name == full_name));
@@ -93,12 +93,9 @@ fn reflog_by_date_for_hash_is_invalid() {
 #[test]
 fn reflog_by_date_for_given_ref_name() {
     for (spec, expected_ref) in [
-        ("main@{1979-02-26 18:30:00}", "main"),
-        ("refs/heads/other@{1979-02-26 18:30:00}", "refs/heads/other"),
-        (
-            "refs/worktree/feature/a@{1979-02-26 18:30:00}",
-            "refs/worktree/feature/a",
-        ),
+        ("main@{42 +0030}", "main"),
+        ("refs/heads/other@{42 +0030}", "refs/heads/other"),
+        ("refs/worktree/feature/a@{42 +0030}", "refs/worktree/feature/a"),
     ] {
         let rec = parse(spec);
 

gix/tests/gix-init.rs

@@ -26,7 +26,7 @@ mod with_overrides {
     #[test]
     #[serial]
     fn order_from_api_and_cli_and_environment() -> gix_testtools::Result {
-        let default_date = "1979-02-26 18:30:00";
+        let default_date = "42 +0030";
         let _env = Env::new()
             .set("GIT_HTTP_USER_AGENT", "agent-from-env")
             .set("GIT_HTTP_LOW_SPEED_LIMIT", "1")

gix/tests/gix/repository/config/identity.rs

@@ -141,7 +141,7 @@ fn author_from_different_config_sections() -> crate::Result {
     let _env = Env::new()
         .set("GIT_CONFIG_GLOBAL", work_dir.join("global.config").to_str().unwrap())
         .set("GIT_CONFIG_SYSTEM", work_dir.join("system.config").to_str().unwrap())
-        .set("GIT_AUTHOR_DATE", "1979-02-26 18:30:00")
+        .set("GIT_AUTHOR_DATE", "42 +0030")
         .unset("GIT_AUTHOR_NAME")
         .set("GIT_COMMITTER_DATE", "1980-02-26 18:30:00 +0000")
         .unset("GIT_COMMITTER_NAME")

gix/tests/gix/revision/spec/from_bytes/reflog.rs

@@ -78,7 +78,7 @@ fn by_index() {
 fn by_date() {
     let repo = repo("complex_graph").unwrap();
 
-    let spec = parse_spec_no_baseline("main@{1979-02-26 18:30:00}", &repo).unwrap();
+    let spec = parse_spec_no_baseline("main@{42 +0030}", &repo).unwrap();
 
     assert_eq!(
         spec,

gix/tests/gix/util.rs

@@ -9,7 +9,7 @@ pub fn hex_to_id(hex: &str) -> gix_hash::ObjectId {
 }
 
 pub fn freeze_time() -> gix_testtools::Env<'static> {
-    let frozen_time = "1979-02-26 18:30:00";
+    let frozen_time = "42 +0030";
     gix_testtools::Env::new()
         .unset("GIT_AUTHOR_NAME")
         .unset("GIT_AUTHOR_EMAIL")