fix: Modules::is_active() now counts everything that doesn't match submodule.active (if present) as inactive.

Author: Byron

gix-submodule/src/is_active_platform.rs

@@ -52,12 +52,11 @@ impl IsActivePlatform {
         if let Some(val) = config.boolean("submodule", Some(name), "active").transpose()? {
             return Ok(val);
         };
-        if let Some(val) = self
-            .search
-            .as_mut()
-            .and_then(|search| search.pattern_matching_relative_path(name, Some(true), attributes))
-            .map(|m| !m.is_excluded())
-        {
+        if let Some(val) = self.search.as_mut().map(|search| {
+            search
+                .pattern_matching_relative_path(name, Some(true), attributes)
+                .map_or(false, |m| !m.is_excluded())
+        }) {
             return Ok(val);
         }
         Ok(match modules.url(name) {

gix-submodule/tests/file/mod.rs

@@ -113,6 +113,40 @@ mod is_active_platform {
         );
         Ok(())
     }
+
+    #[test]
+    fn pathspecs_matter_even_if_they_do_not_match() -> crate::Result {
+        let module = multi_modules()?;
+        assert_eq!(
+            assume_valid_active_state(
+                &module,
+                &gix_config::File::from_str("[submodule]\n active = submodule ")?,
+                Default::default()
+            )?,
+            &[
+                ("submodule", true),
+                ("a/b", false),
+                (".a/..c", false),
+                ("a/d\\", false),
+                ("a\\e", false)
+            ]
+        );
+        assert_eq!(
+            assume_valid_active_state(
+                &module,
+                &gix_config::File::from_str("[submodule]\n active = :!submodule ")?,
+                Default::default()
+            )?,
+            &[
+                ("submodule", false),
+                ("a/b", true),
+                (".a/..c", true),
+                ("a/d\\", true),
+                ("a\\e", true)
+            ]
+        );
+        Ok(())
+    }
 }
 
 mod path {