Skip to content

Commit edd1c43

Browse files
committed
Use bash for everything on all platforms in release workflow
The way environment variables are being set and accessed assumes a Bourne-style (POSIX-like) shell, but PowerShell was being used on Windows for some steps where this was being assumed. It's possible to set bash only for some steps, but that is more complex to understand than using it for everything.
1 parent 55cffe4 commit edd1c43

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

.github/workflows/release.yml

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,6 @@
1212

1313
name: release
1414

15-
env:
16-
RUST_BACKTRACE: 1
17-
CARGO_TERM_COLOR: always
18-
CLICOLOR: 1
19-
2015
on:
2116
workflow_dispatch:
2217
push:
@@ -25,6 +20,16 @@ on:
2520
# - fix-releases
2621
tags:
2722
- "v.*"
23+
24+
env:
25+
RUST_BACKTRACE: 1
26+
CARGO_TERM_COLOR: always
27+
CLICOLOR: 1
28+
29+
defaults:
30+
run:
31+
shell: bash
32+
2833
jobs:
2934
create-release:
3035
name: create-release
@@ -167,7 +172,6 @@ jobs:
167172
path: artifacts
168173

169174
- name: Set release upload URL and release version
170-
shell: bash
171175
run: |
172176
release_upload_url="$(cat artifacts/release-upload-url)"
173177
echo "RELEASE_UPLOAD_URL=$release_upload_url" >> $GITHUB_ENV
@@ -193,7 +197,6 @@ jobs:
193197
/target/arm-unknown-linux-gnueabihf/release/${{ env.EXE_NAME }} \
194198
/target/arm-unknown-linux-gnueabihf/release/gix
195199
- name: Build archive
196-
shell: bash
197200
run: |
198201
staging="gitoxide-${{ matrix.feature }}-${{ env.RELEASE_VERSION }}-${{ matrix.target }}"
199202
mkdir -p "$staging"

0 commit comments

Comments
 (0)