update msrv to 1.79, add rust-toolchain.toml
#1809
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, use the root `[workspace.package]` as a source of truth for all crates `repository`, `edition`, `license`, and `rust-version`. Also used for `authors` only if the only author listed was Sebastian Thiel.
|
This currently doesn't touch any of the CI --- if accepted, those might also need to change to respect |
Byron
reviewed
Jan 26, 2025
There was a problem hiding this comment.
Thanks for the initiative!
I left a comment which attempts to direct it a bit.
This PR can't be happening as:
- the MSRV doesn't have to be driven by tests
- this project can't use workspace settings as it would affect changelog generation. Changelogs and versioning depend on per-crate file changes in Git, which won't happen if these are inherited.
Thanks for your understanding - I hope we can make some improvements in another way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1808
Additionally, use the root
[workspace.package]as a source of truth for all cratesrepository,edition,license, andrust-version. Also used forauthorsonly if the only author listed was Sebastian Thiel.