fix: use platform path separator instead of /
#1905
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nik-rev, thanks a lot for contributing! I left a comment in the original helix PR explaining why this PR here has to be closed. CC @cruessler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on Git Blame for Helix and some people on Windows experienced issues where they don't see the blame (helix-editor/helix#13133)
I found the reason is because Gix uses
/for path separator always, instead of using the platform's separator. This PR fixes thatnote: the way I'm turning
MAIN_SEPARATOR_STRinto a byte is a bit awkward here, I wish there was some kind ofMAIN_SEPARATOR_BYTE