feat: get string view

Author: KobeBryant114514

include/binarystream/ReadOnlyBinaryStream.hpp

@@ -113,6 +113,10 @@ class ReadOnlyBinaryStream {
     [[nodiscard]] BSAPI std::string getShortString();
     [[nodiscard]] BSAPI std::string getLongString();
 
+    [[nodiscard]] BSAPI std::string_view getStringView();
+    [[nodiscard]] BSAPI std::string_view getShortStringView();
+    [[nodiscard]] BSAPI std::string_view getLongStringView();
+
     BSAPI void          getRawBytes(std::string& rawBuffer, size_t length);
     [[nodiscard]] BSAPI std::string getRawBytes(size_t length);
 };

src/binarystream/BinaryStream.cpp

@@ -123,19 +123,19 @@ void BinaryStream::writeSignedBigEndianInt(int32_t value) { write(value, true);
 void BinaryStream::writeString(std::string_view value) {
     auto size = static_cast<uint32_t>(value.size());
     writeUnsignedVarInt(size);
-    writeRawBytes(value, size);
+    writeRawBytes(value, static_cast<size_t>(size));
 }
 
 void BinaryStream::writeShortString(std::string_view value) {
-    auto size = static_cast<uint16_t>(value.size());
+    auto size = static_cast<int16_t>(value.size());
     writeSignedShort(size);
-    writeRawBytes(value, size);
+    writeRawBytes(value, static_cast<size_t>(size));
 }
 
 void BinaryStream::writeLongString(std::string_view value) {
     auto size = static_cast<int>(value.size());
     writeSignedInt(size);
-    writeRawBytes(value, size);
+    writeRawBytes(value, static_cast<size_t>(size));
 }
 
 void BinaryStream::writeUnsignedInt24(uint32_t value) {

src/binarystream/ReadOnlyBinaryStream.cpp

@@ -163,7 +163,7 @@ uint32_t ReadOnlyBinaryStream::getUnsignedVarInt() noexcept {
         }
 
         byte   = static_cast<uint8_t>(mBufferView[mReadPointer++]);
-        value |= (byte & 0x7F) << shift;
+        value |= static_cast<uint32_t>(byte & 0x7F) << shift;
         shift += 7;
 
     } while (byte & 0x80);
@@ -218,17 +218,17 @@ int32_t ReadOnlyBinaryStream::getSignedBigEndianInt() noexcept {
 
 void ReadOnlyBinaryStream::getString(std::string& outString) {
     uint32_t length = getUnsignedVarInt();
-    getRawBytes(outString, length);
+    getRawBytes(outString, static_cast<size_t>(length));
 }
 
 void ReadOnlyBinaryStream::getShortString(std::string& outString) {
     short length = getSignedShort();
-    getRawBytes(outString, length);
+    getRawBytes(outString, static_cast<size_t>(length));
 }
 
 void ReadOnlyBinaryStream::getLongString(std::string& outString) {
     int length = getSignedInt();
-    getRawBytes(outString, length);
+    getRawBytes(outString, static_cast<size_t>(length));
 }
 
 std::string ReadOnlyBinaryStream::getString() {
@@ -249,14 +249,35 @@ std::string ReadOnlyBinaryStream::getLongString() {
     return result;
 }
 
+std::string_view ReadOnlyBinaryStream::getStringView() {
+    auto length   = static_cast<size_t>(getUnsignedVarInt());
+    auto result   = mBufferView.substr(mReadPointer, length);
+    mReadPointer += length;
+    return result;
+}
+
+std::string_view ReadOnlyBinaryStream::getShortStringView() {
+    auto length   = static_cast<size_t>(getSignedShort());
+    auto result   = mBufferView.substr(mReadPointer, length);
+    mReadPointer += length;
+    return result;
+}
+
+std::string_view ReadOnlyBinaryStream::getLongStringView() {
+    auto length   = static_cast<size_t>(getSignedInt());
+    auto result   = mBufferView.substr(mReadPointer, length);
+    mReadPointer += length;
+    return result;
+}
+
 uint32_t ReadOnlyBinaryStream::getUnsignedInt24() noexcept {
     if (mReadPointer + 3 > mBufferView.size()) {
         mHasOverflowed = true;
         return 0;
     }
     uint32_t value = 0;
     if (mBigEndian) {
-        value  = static_cast<uint8_t>(mBufferView[mReadPointer++]) << 16;
+        value  = static_cast<uint32_t>(static_cast<uint8_t>(mBufferView[mReadPointer++]) << 16);
         value |= static_cast<uint32_t>(static_cast<uint8_t>(mBufferView[mReadPointer++])) << 8;
         value |= static_cast<uint32_t>(static_cast<uint8_t>(mBufferView[mReadPointer++]));
     } else {

xmake.lua

@@ -50,6 +50,7 @@ target("BinaryStream")
         add_cxflags(
             "-Wall",
             "-Wextra",
+            "-Wconversion",
             "-pedantic",
             "-fexceptions",
             "-stdlib=libc++",