Merge pull request #10 from Glebsky/checks

✨ feat(lang): optimize LangGeneratorCommand syntax

Author: Glebsky

.travis.yml

@@ -1,9 +1,8 @@
 language: php
 
 php:
-  - 7.3
-  - 7.4
-  - 8.0
+  - 8.2
+  - 8.3
 
 install:
   - composer update && composer install

README.md

@@ -31,15 +31,15 @@ It will create configuration file in `app/config` with name `lang-generator`
 
 ### About configuration
 
-<b>file_type</b>: is responsible for the type of the generated file. It is possible to generate both a json and an php array files. Posible values: `array` , `json`
+<b>file_type</b>: is responsible for the type of the generated file. It is possible to generate both a json and a php array files. Possible values: `array` , `json`
 
 ---
 
-<b>file_name</b>: is responsible for the name of the generated files. By default it is `lang`.
+<b>file_name</b>: is responsible for the name of the generated files. By default, it is `lang`.
 
 ---
 
-<b>languages</b>:  is responsible for the generated languages and accepts an array. Language folders with the specified data will be created. By default it just `en`.
+<b>languages</b>:  is responsible for the generated languages and accepts an array. Language folders with the specified data will be created. By default, it just `en`.
 
 ---
 
@@ -54,7 +54,7 @@ Existing keys will not be removed, only new ones will be added.
 php artisan lang:generate
 ```
 it will create new language files with found translation keys.
-By default name of lang file is `lang`
+By default, name of lang file is `lang`
 
 ![title](https://i.imgur.com/hvDrlVO.jpeg)
 
@@ -68,21 +68,21 @@ php artisan lang:generate --type= --name= --langs= --sync --clear --append --pat
 
 `--type=` or `-T`:
 
-is responsible for the type of the generated file. It is possible to generate both a json and an php array files. Posible values: `array` , `json`. <br>Example: `php artisan lang:generate --type=json`
+is responsible for the type of the generated file. It is possible to generate both a json and a php array files. Possible values: `array` , `json`. <br>Example: `php artisan lang:generate --type=json`
 
 ---
 
 `--name=` or `-N`:
 
-is responsible for the name of the generated files. By default it is `lang`. 
+is responsible for the name of the generated files. By default, it is `lang`. 
 
 Example: `php artisan lang:generate --name="pagination"`
 
 ---
 
 `--langs=` or `-L`:
 
-is responsible for the generated languages and accepts an array. Language folders with the specified data will be created. By default it just `en`. <br>Example: `php artisan lang:generate --langs="en" --langs="es"`
+is responsible for the generated languages and accepts an array. Language folders with the specified data will be created. By default, it just `en`. <br>Example: `php artisan lang:generate --langs="en" --langs="es"`
 
 ---
 
@@ -104,7 +104,7 @@ Example: `php artisan lang:generate --clear`
 
 `--append` or `-A`:
 
-If you specify this flag, new translations found will be added at the end of the JSON file, which might be useful for automatisation or version control. Only usable with JSON as type.
+If you specify this flag, new translations found will be added at the end of the JSON file, which might be useful for automation or version control. Only usable with JSON as type.
 
 Example: `php artisan lang:generate --type=json --append`
 

composer.json

@@ -14,9 +14,8 @@
     ],
     "minimum-stability": "stable",
     "require": {
-        "php": "^7.3|^8.0",
-        "illuminate/collections": ">=8.0.0",
-        "illuminate/console": ">=5.1"
+        "php": "^8.2",
+        "laravel/framework": "^11.9"
     },
     "autoload": {
         "psr-4": {

composer.lock

@@ -4,14 +4,13 @@
 
 use Glebsky\LaravelLangGenerator\LangService;
 use Illuminate\Console\Command;
+use JsonException;
 
 class LangGeneratorCommand extends Command
 {
     protected $signature = 'lang:generate {--T|type=} {--N|name=} {--L|langs=*} {--S|sync} {--C|clear} {--P|path=} {--A|append}';
-
     protected $description = 'Searches for multilingual phrases in Laravel project and automatically generates language files for you.';
-
-    protected $manager;
+    protected LangService $manager;
 
     public function __construct(LangService $manager)
     {
@@ -23,7 +22,10 @@ public function __construct(LangService $manager)
         $this->manager->languages = config('lang-generator.languages');
     }
 
-    public function handle()
+    /**
+     * @throws JsonException
+     */
+    public function handle(): void
     {
         $this->manager->output = $this->output;
 
@@ -37,7 +39,7 @@ public function handle()
         $this->manager->languages = $this->option('langs') ?: $this->manager->languages;
         $this->manager->path = $this->option('path');
 
-        if ($this->manager->doAppend === true && $this->manager->fileType !== 'json') {
+        if ($this->manager->doAppend && $this->manager->fileType !== 'json') {
             $this->error('The append option is only possible for type json.');
 
             return;