Skip to content

Commit 3d7416c

Browse files
committed
Add follow ups as todo comments
1 parent 7a84381 commit 3d7416c

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

src/_pytest/compat.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,10 +117,6 @@ def getfuncargnames(
117117
118118
The name parameter should be the original name in which the function was collected.
119119
"""
120-
# if name == "session_request":
121-
# import pdb
122-
# breakpoint()
123-
124120
# TODO(RonnyPfannschmidt): This function should be refactored when we
125121
# revisit fixtures. The fixture mechanism should ask the node for
126122
# the fixture names, and not try to obtain directly from the

src/_pytest/fixtures.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,7 @@ def get_scope_node(node: nodes.Node, scope: Scope) -> nodes.Node | None:
152152
assert_never(scope)
153153

154154

155+
# TODO: Try to use FixtureFunctionDefinition instead of the marker
155156
def getfixturemarker(obj: object) -> FixtureFunctionMarker | None:
156157
"""Return fixturemarker or None if it doesn't exist"""
157158
if isinstance(obj, FixtureFunctionDefinition):
@@ -1186,6 +1187,7 @@ def __call__(self, function: FixtureFunction) -> FixtureFunctionDefinition:
11861187
return fixture_definition
11871188

11881189

1190+
# TODO: paramspec/return type annotation tracking and storing
11891191
class FixtureFunctionDefinition:
11901192
def __init__(
11911193
self,

0 commit comments

Comments
 (0)