Javascript Linting/Analysis of JS files (#361)

# Description

This adds a makefile target to run a check on js files through jshint:

`make js-lint`

Experimented with a couple other tools such as `eslint` but they proved cumbersome and overly strict, requiring annotations in script files to direct behavior more and more. Things like spacing, undefined functions (because they were defined in a .go binding) etc. were problematic.

Settled on `jshint` since it's looser in its rules. Primarily we are testing for:

* syntax errors that will break execution
* Incompatible keywords
* "good" practices such as semicolons at the end of lines.

There is some filtering out of noise from the docker image (npm error, npm warn, etc) that can be ignored. Otherwise, exits with code 1 if errors are detected, and reports errors.

This _should_ allow us to implement in CI/CD processes.

## Changes

- `js-lint` make target.
- Handled existing js errors reported (a lot).

### Example Output

**With errors:**

```
√ ~/dev/GoMud % make js-lint
_datafiles/sample-scripts/spells/harmmulti.js: line 10, col 27, Expected ')' and instead saw 'eActor'.
_datafiles/sample-scripts/spells/harmmulti.js: line 10, col 44, Expected an assignment or function call and instead saw an expression.
_datafiles/sample-scripts/spells/harmmulti.js: line 10, col 72, Missing semicolon.
_datafiles/sample-scripts/spells/harmmulti.js: line 10, col 72, Expected an identifier and instead saw ')'.
_datafiles/sample-scripts/spells/harmmulti.js: line 10, col 72, Expected an assignment or function call and instead saw an expression.

5 errors
make: *** [js-lint] Error 1
√ ~/dev/GoMud %   
```

**Without errors:**

```
√ ~/dev/GoMud % make js-lint
√ ~/dev/GoMud %   
```

## Links
#342

Author: Volte6

.jshintignore

@@ -0,0 +1,3 @@
+_datafiles/html/public/static/js/xterm.4.19.0.js
+_datafiles/html/public/static/js/xterm-addon-fit.js
+_datafiles/html/admin/static/js/htmx.2.0.3.js

.jshintrc

@@ -0,0 +1,4 @@
+{
+    "esversion": 6
+}
+    

Makefile

@@ -113,6 +113,14 @@ coverage:
 	go tool cover -html=bin/covdatafiles/cover.out && \
 	rm -rf bin
 
+.PHONY: js-lint
+js-lint:
+#   Grep filtering it to remove errors reported by docker image around npm packages
+#   if "### errors" is found in the output, exits with an error code of 1
+#   This should allow us to use it in CI/CD
+	@docker run --rm -v "$(PWD)":/app -w /app node:20 npx jshint . \
+	 2>&1 | grep -v "^npm " | tee /dev/stderr | grep -Eq "^[0-9]+ errors" && exit 1 || true
+
 #
 #
 # Cert generation for testing

_datafiles/sample-scripts/mobs/item-gold-quest.js

@@ -13,9 +13,9 @@ const REQUIRED_ITEM_ID      = 10001;
 const REQUIRED_GOLD_AMOUNT  = 10;
 
 // This corresponds to the quest defined in the _datafiles/quests/ folder.
-const QUEST_START_ID        = "1000000-start"       // All quests begin with #-start
-const QUEST_NEXT_STEP_ID    = "1000000-givegold"    // Quest steps can be called #-anything
-const QUEST_END_ID          = "1000000-end"         // All quests end with #-end
+const QUEST_START_ID        = "1000000-start";       // All quests begin with #-start
+const QUEST_NEXT_STEP_ID    = "1000000-givegold";    // Quest steps can be called #-anything
+const QUEST_END_ID          = "1000000-end";         // All quests end with #-end
 
 
 //
@@ -129,7 +129,7 @@ function onGive(mob, room, eventDetails) {
         //
         // Give them the next step of the quest
         //
-        user.GiveQuest(QUEST_NEXT_STEP_ID)
+        user.GiveQuest(QUEST_NEXT_STEP_ID);
 
         return true;
     }
@@ -172,14 +172,14 @@ function onGive(mob, room, eventDetails) {
             //
             excessGold = eventDetails.gold - REQUIRED_GOLD_AMOUNT;
             if ( excessGold > 0 ) {
-                mob.Command("say Here's your change.")
+                mob.Command("say Here's your change.");
                 mob.Command("give "+String(excessGold)+" gold " + user.ShorthandId()); // Give it to the player using shorthand
             }
 
             //
             // They have now completed the entire quest, all steps are complete.
             //
-            user.GiveQuest(QUEST_END_ID)
+            user.GiveQuest(QUEST_END_ID);
 
             return true;
         }

_datafiles/sample-scripts/spells/harmarea.js

@@ -1,15 +1,15 @@
 
-HARM_DICE_QTY = 1
-HARM_DICE_SIDES = 2
-SPELL_DESCRIPTION = '<ansi fg="222">sample harmful area spell</ansi>'
+HARM_DICE_QTY = 1;
+HARM_DICE_SIDES = 2;
+SPELL_DESCRIPTION = '<ansi fg="222">sample harmful area spell</ansi>';
 
 // Called when the casting is initialized (cast command)
 // Return false if the casting should be ignored/aborted
 function onCast(sourceActor, targetActors) {
 
     SendUserMessage(sourceActor.UserId(), 'You begin to chant softly.');
     SendRoomMessage(sourceActor.GetRoomId(), sourceActor.GetCharacterName(true)+' begins to chant softly.', sourceActor.UserId());
-    return true
+    return true;
 }
 
 function onWait(sourceActor, targetActors) {

_datafiles/sample-scripts/spells/harmmulti.js

@@ -1,15 +1,15 @@
 
-HARM_DICE_QTY = 1
-HARM_DICE_SIDES = 2
-SPELL_DESCRIPTION = '<ansi fg="222">sample harmful group spell</ansi>'
+HARM_DICE_QTY = 1;
+HARM_DICE_SIDES = 2;
+SPELL_DESCRIPTION = '<ansi fg="222">sample harmful group spell</ansi>';
 
 // Called when the casting is initialized (cast command)
 // Return false if the casting should be ignored/aborted
 function onCast(sourceActor, targetActors) {
 
     SendUserMessage(sourceActor.UserId(), 'You begin to chant softly.');
     SendRoomMessage(sourceActor.GetRoomId(), sourceActor.GetCharacterName(true)+' begins to chant softly.', sourceActor.UserId());
-    return true
+    return true;
 }
 
 function onWait(sourceActor, targetActors) {

_datafiles/sample-scripts/spells/harmsingle.js

@@ -1,15 +1,15 @@
 
-HARM_DICE_QTY = 1
-HARM_DICE_SIDES = 2
-SPELL_DESCRIPTION = '<ansi fg="222">sample harmful single target spell</ansi>'
+HARM_DICE_QTY = 1;
+HARM_DICE_SIDES = 2;
+SPELL_DESCRIPTION = '<ansi fg="222">sample harmful single target spell</ansi>';
 
 // Called when the casting is initialized (cast command)
 // Return false if the casting should be ignored/aborted
 function onCast(sourceActor, targetActor) {
 
     SendUserMessage(sourceActor.UserId(), 'You begin to chant softly.');
     SendRoomMessage(sourceActor.GetRoomId(), sourceActor.GetCharacterName(true)+' begins to chant softly.', sourceActor.UserId());
-    return true
+    return true;
 }
 
 function onWait(sourceActor, targetActor) {

_datafiles/sample-scripts/spells/helparea.js

@@ -1,7 +1,7 @@
 
-HEAL_DICE_QTY = 1
-HEAL_DICE_SIDES = 2
-SPELL_DESCRIPTION = '<ansi fg="222">sample helpful area spell</ansi>'
+HEAL_DICE_QTY = 1;
+HEAL_DICE_SIDES = 2;
+SPELL_DESCRIPTION = '<ansi fg="222">sample helpful area spell</ansi>';
 
 
 // Called when the casting is initialized (cast command)
@@ -10,7 +10,7 @@ function onCast(sourceActor, targetActors) {
 
     SendUserMessage(sourceActor.UserId(), 'You begin to chant softly.');
     SendRoomMessage(sourceActor.GetRoomId(), sourceActor.GetCharacterName(true)+' begins to chant softly.', sourceActor.UserId());
-    return true
+    return true;
 }
 
 function onWait(sourceActor, targetActors) {

_datafiles/sample-scripts/spells/helpmulti.js

@@ -1,7 +1,7 @@
 
-HEAL_DICE_QTY = 1
-HEAL_DICE_SIDES = 2
-SPELL_DESCRIPTION = '<ansi fg="222">sample helpful group spell</ansi>'
+HEAL_DICE_QTY = 1;
+HEAL_DICE_SIDES = 2;
+SPELL_DESCRIPTION = '<ansi fg="222">sample helpful group spell</ansi>';
 
 
 // Called when the casting is initialized (cast command)
@@ -10,7 +10,7 @@ function onCast(sourceActor, targetActors) {
 
     SendUserMessage(sourceActor.UserId(), 'You begin to chant softly.');
     SendRoomMessage(sourceActor.GetRoomId(), sourceActor.GetCharacterName(true)+' begins to chant softly.', sourceActor.UserId());
-    return true
+    return true;
 }
 
 function onWait(sourceActor, targetActors) {

_datafiles/sample-scripts/spells/helpsingle.js

@@ -1,15 +1,15 @@
 
-HEAL_DICE_QTY = 1
-HEAL_DICE_SIDES = 2
-SPELL_DESCRIPTION = '<ansi fg="222">sample helpful single target spell</ansi>'
+HEAL_DICE_QTY = 1;
+HEAL_DICE_SIDES = 2;
+SPELL_DESCRIPTION = '<ansi fg="222">sample helpful single target spell</ansi>';
 
 // Called when the casting is initialized (cast command)
 // Return false if the casting should be ignored/aborted
 function onCast(sourceActor, targetActor) {
 
     SendUserMessage(sourceActor.UserId(), 'You begin to chant softly.');
     SendRoomMessage(sourceActor.GetRoomId(), sourceActor.GetCharacterName(true)+' begins to chant softly.', sourceActor.UserId());
-    return true
+    return true;
 }
 
 function onWait(sourceActor, targetActor) {