swapping around and to avoid null ptr deref (#389)

srmeier · web-flow · commit 4ca8a5a36f8a · 2025-05-19T10:23:13.000-07:00
# Description Addressing issue #388 by swapping around the `addRoomToMemory` and `SaveRoomTemplate` function calls in the `CreateZone` function. ## Changes - Calling `addRoomToMemory` before `SaveRoomTemplate` in `CreateZone`.
diff --git a/internal/rooms/roommanager.go b/internal/rooms/roommanager.go
@@ -696,11 +696,11 @@ func CreateZone(zoneName string) (roomId int, err error) {
 		return 0, err
 	}
 
+	addRoomToMemory(newRoom)
+
 	// save to the flat file
 	SaveRoomTemplate(*newRoom)
 
-	addRoomToMemory(newRoom)
-
 	// write room to the folder under the new ID
 	return newRoom.RoomId, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -696,11 +696,11 @@ func CreateZone(zoneName string) (roomId int, err error) {`
`696`	`696`	`return 0, err`
`697`	`697`	`}`
`698`	`698`
	`699`	`+ addRoomToMemory(newRoom)`
	`700`	`+`
`699`	`701`	`// save to the flat file`
`700`	`702`	`SaveRoomTemplate(*newRoom)`
`701`	`703`
`702`		`- addRoomToMemory(newRoom)`
`703`		`-`
`704`	`704`	`// write room to the folder under the new ID`
`705`	`705`	`return newRoom.RoomId, nil`
`706`	`706`	`}`