Refactored ItemLookData to use string-based type comparisons

Changed:
  - Replaced boolean fields (IsWeapon, IsReadable, etc.) with Type and
Subtype strings
  - Replaced IsCursed/IsEnchanted booleans with extensible Adjectives
map
  - Updated templates to use string equality checks (e.g., {{if eq .Type
"readable"}})

Fixed:
  - Corrected TimeoutMods YAML formatting from multi-line to single-line

Author: MorquinDevlar

_datafiles/config.yaml

@@ -420,9 +420,8 @@ Network:
   # - TimeoutMods -
   #   Whether Admin/Mod users get timed out when reaching MaxIdleSeconds
   #   If set to false, Admins & Mods never get force disconnected.
-  TimeoutMods:
-    false
-    # - ZombieSeconds -
+  TimeoutMods: false
+  # - ZombieSeconds -
   #   How many seconds a character stays active/in game after a network connection
   #   is lost. Set to 0 to instantly log out characters (exploitable).
   ZombieSeconds: 60

_datafiles/world/default/templates/descriptions/look-item.screenreader.template

@@ -2,20 +2,20 @@
 You look at the {{ .Item.Name }} {{ .Location }}:
 
 {{ .ItemSpec.Description }}
-{{- if .IsReadable }}
+{{- if eq .Type "readable" }}
 You should probably read this.
-{{- else if .IsDrinkable }}
+{{- else if eq .Subtype "drinkable" }}
 You could probably drink this.
-{{- else if .IsEdible }}
+{{- else if eq .Subtype "edible" }}
 You could probably eat this.
-{{- else if .IsLockpicks }}
+{{- else if eq .Type "lockpicks" }}
 These are used with the picklock command.
-{{- else if .IsKey }}
+{{- else if eq .Type "key" }}
 When you find the right door, keys are added to your keyring automatically.
-{{- else if .IsWearable }}
+{{- else if eq .Subtype "wearable" }}
 It looks like wearable {{ .ItemSpec.Type }} equipment.
 {{- end }}
-{{- if .IsWeapon }}
+{{- if eq .Type "weapon" }}
 It looks like a {{ .WeaponHands }}-Handed weapon.
 {{- if eq .WeaponType "claws" }}
 It looks like a claws weapon. These can be dual wielded without training.
@@ -29,9 +29,9 @@ It requires an extra {{ .WaitRounds }} round(s) between attacks.
 {{- if .HasUses }}
 It has {{ .UsesRemaining }}/{{ .MaxUses }} uses remaining.
 {{- end }}
-{{- if .IsCursed }}
+{{- if index .Adjectives "cursed" }}
 It's CURSED! Once equipped, it cannot be removed without magical help.
 {{- end }}
-{{- if .IsEnchanted }}
+{{- if index .Adjectives "enchanted" }}
 It glows with a magical aura (enchantment level {{ .EnchantLevel }}).
 {{- end }}

_datafiles/world/default/templates/descriptions/look-item.template

@@ -2,20 +2,20 @@
 You look at the <ansi fg="item">{{ .Item.DisplayName }}</ansi> {{ .Location }}:
 
 {{ .ItemSpec.Description }}
-{{- if .IsReadable }}
+{{- if eq .Type "readable" }}
 - You should probably <ansi fg="command">read</ansi> this.
-{{- else if .IsDrinkable }}
+{{- else if eq .Subtype "drinkable" }}
 - You could probably <ansi fg="command">drink</ansi> this.
-{{- else if .IsEdible }}
+{{- else if eq .Subtype "edible" }}
 - You could probably <ansi fg="command">eat</ansi> this.
-{{- else if .IsLockpicks }}
+{{- else if eq .Type "lockpicks" }}
 - These are used with the <ansi fg="command">picklock</ansi> command.
-{{- else if .IsKey }}
+{{- else if eq .Type "key" }}
 - When you find the right door, keys are added to your keyring automatically.
-{{- else if .IsWearable }}
+{{- else if eq .Subtype "wearable" }}
 - It looks like wearable <ansi fg="magenta">{{ .ItemSpec.Type }}</ansi> equipment.
 {{- end }}
-{{- if .IsWeapon }}
+{{- if eq .Type "weapon" }}
 - It looks like a <ansi fg="yellow">{{ .WeaponHands }}-Handed</ansi> weapon.
 {{- if eq .WeaponType "claws" }}
 - It looks like a <ansi fg="yellow">claws</ansi> weapon. These can be dual wielded without training.
@@ -29,9 +29,9 @@ You look at the <ansi fg="item">{{ .Item.DisplayName }}</ansi> {{ .Location }}:
 {{- if .HasUses }}
 - It has <ansi fg="yellow">{{ .UsesRemaining }}/{{ .MaxUses }}</ansi> uses remaining.
 {{- end }}
-{{- if .IsCursed }}
+{{- if index .Adjectives "cursed" }}
 - It's <ansi fg="red-bold">CURSED!</ansi> Once equipped, it cannot be removed without magical help.
 {{- end }}
-{{- if .IsEnchanted }}
+{{- if index .Adjectives "enchanted" }}
 - It glows with a <ansi fg="enchanted">magical aura</ansi> (enchantment level {{ .EnchantLevel }}).
 {{- end }}

internal/items/items.go

@@ -172,23 +172,16 @@ func (i *Item) Validate() {
 type ItemLookData struct {
 	Item          *Item
 	ItemSpec      ItemSpec
-	Location      string // "in your backpack", "you are wearing"
-	IsWeapon      bool
-	IsReadable    bool
-	IsDrinkable   bool
-	IsEdible      bool
-	IsLockpicks   bool
-	IsKey         bool
-	IsWearable    bool
-	IsUsable      bool
+	Location      string          // "in your backpack", "you are wearing"
+	Type          string          // Item type for template comparisons
+	Subtype       string          // Item subtype for template comparisons
+	Adjectives    map[string]bool // Extensible flags (cursed, enchanted, etc)
 	WeaponHands   int
 	WeaponType    string // "claws", "shooting", etc.
 	WaitRounds    int
 	HasUses       bool
 	UsesRemaining int
 	MaxUses       int
-	IsCursed      bool
-	IsEnchanted   bool
 	EnchantLevel  int
 }
 
@@ -197,7 +190,10 @@ func (i *Item) GetLookData(location string) ItemLookData {
 	// Defensive check for nil item
 	if i == nil {
 		return ItemLookData{
-			Location: location,
+			Location:   location,
+			Type:       "",
+			Subtype:    "",
+			Adjectives: make(map[string]bool),
 		}
 	}
 
@@ -207,23 +203,20 @@ func (i *Item) GetLookData(location string) ItemLookData {
 		Item:          i,
 		ItemSpec:      iSpec,
 		Location:      location,
-		IsWeapon:      iSpec.Type == Weapon,
-		IsReadable:    iSpec.Type == Readable,
-		IsDrinkable:   iSpec.Subtype == Drinkable,
-		IsEdible:      iSpec.Subtype == Edible,
-		IsLockpicks:   iSpec.Type == Lockpicks,
-		IsKey:         iSpec.Type == Key,
-		IsWearable:    iSpec.Subtype == Wearable,
-		IsUsable:      iSpec.Subtype == Usable,
+		Type:          string(iSpec.Type),
+		Subtype:       string(iSpec.Subtype),
+		Adjectives:    make(map[string]bool),
 		HasUses:       iSpec.Uses > 0,
 		UsesRemaining: i.Uses,
 		MaxUses:       iSpec.Uses,
-		IsCursed:      i.IsCursed(),
-		IsEnchanted:   i.Enchantments > 0,
 		EnchantLevel:  int(i.Enchantments),
 	}
 
-	if data.IsWeapon {
+	// Set adjectives for extensibility
+	data.Adjectives["cursed"] = i.IsCursed()
+	data.Adjectives["enchanted"] = i.Enchantments > 0
+
+	if iSpec.Type == Weapon {
 		data.WeaponHands = iSpec.Hands
 		data.WaitRounds = iSpec.WaitRounds