Fix for issue #434

Author: Volte6

_datafiles/world/default/mobs/frostfang/scripts/2-guard-hungry.js

@@ -86,38 +86,34 @@ function onIdle(mob, room) {
     round = UtilGetRoundNumber();
 
     grumbled = false;
-    userIds = room.GetPlayers();
+    allPlayers = room.GetPlayers();
 
     playersTold = mob.GetTempData('playersTold');
     if ( playersTold === null ) {
         playersTold = {};
     }
 
-    if ( userIds.length > 0 ) {
+    if ( allPlayers.length > 0 ) {
 
-        for (var i = 0; i < userIds.length; i++) {
+        for( var i in allPlayers ) {
 
-            if ( userIds[i] in playersTold ) {
-                if ( round < playersTold[userIds[i]] ) {
+            if ( allPlayers[i].UserId() in playersTold ) {
+                if ( round < playersTold[allPlayers[i].UserId()] ) {
                     continue;
                 }
             }
-
-            if ( (user = GetUser(userIds[i])) == null ) {
-                continue;
-            }
-
-            if ( !user.HasQuest("4-start") ) {
+            
+            if ( !allPlayers[i].HasQuest("4-start") ) {
                 if ( !grumbled ) {
                     mob.Command("emote pats his belly as it grumbles.");
                     grumbled = true;
                 }
-                mob.Command("sayto @" + String(userIds[i]) + " I'm so hungry.");
+                mob.Command("sayto @" + String(allPlayers[i].UserId()) + " I'm so hungry.");
             } else {
-                playersTold[userIds[i]] = round + 500;
+                playersTold[allPlayers[i].UserId()] = round + 500;
             }
 
-            playersTold[userIds[i]] = round + 5;
+            playersTold[allPlayers[i].UserId()] = round + 5;
             // Don't need to repeat to every player.
             break;
         }

_datafiles/world/default/rooms/catacombs/136.js

@@ -21,11 +21,9 @@ function onCommand(cmd, rest, user, room) {
 
 
     players = room.GetPlayers();
-    for (var i = 0; i < players.length; i++) {
-        if ( (user = GetUser(players[i])) !== null ) {
-            SendRoomMessage(138, user.GetCharacterName(true)+" falls into the room from above.", user.UserId());
-            user.MoveRoom(138);
-        }
+    for( var i in players ) {
+        SendRoomMessage(138, players[i].GetCharacterName(true)+" falls into the room from above.", players[i].UserId());
+        players[i].MoveRoom(138);
     }
 
     return true;