Replaced slowwalk/fastwalk settings with unified walkspeed option and added automatic area creation

Added:
  - New walkspeed setting with three modes (slow/normal/fast) replacing
separate
  slowwalk/fastwalk options
  - Automatic area creation based on GMCP area information when mapping
  (autocreateareas setting)
  - mmp.roomArea function for moving rooms between areas
  - Support for cross-area exits with automatic area switching during
mapping

Changed:
  - Simplified walking speed logic by consolidating into single
walkspeed setting
  - Modified makeroom function to accept optional target area ID for
cross-area
  room creation
  - Improved error handling in speedwalking with nil checks

Fixed:
  - Stopwatch error when failpath is called without timer initialization
  - Missing nil check for mmp.specials in stop function

Author: MorquinDevlar

src/scripts/GoMudMapper/core/load_settings.lua

@@ -85,6 +85,8 @@ function mmp.startup()
             options = "1-5"
         elseif opt == "echocolour" then
             options = "See mcolor for options"
+        elseif opt == "walkspeed" then
+            options = "slow|normal|fast"
         else
             options = tostring(displayValue)
         end

src/scripts/GoMudMapper/core/mconfig_settings_functions.lua

@@ -75,14 +75,5 @@ function mmp.changeMapSource()
 	end
 end
 
-function mmp.setSlowWalk()
-	if mmp.settings.slowwalk then
-		mmp.echo(
-			"Will walk 'slowly' - that is, only try to move in a direction once per room, and move again once we've arrived. This will make us better walkers when it's very laggy, as we won't spam directions unnecessarily and miss certain turns - but it does mean that if we fail to move for some reason, we won't retry again either at all."
-		)
-	else
-		mmp.echo("Will walk as quick as we can!")
-	end
-end
 
 -- GoMud-specific settings functions can be added here

src/scripts/GoMudMapper/core/option_definitions.lua

@@ -36,18 +36,22 @@ mmp.option_definitions = {
         onChange = mmp.changeLaglevel
     },
 
-    slowwalk = {
-        default = false,
-        type = "boolean",
-        description = "Walk slowly instead of as quick as possible?",
-        onChange = mmp.setSlowWalk
-    },
-    
-    fastwalk = {
-        default = false,
-        type = "boolean",
-        description = "Walk as quick as possible instead of waiting for prompts?",
-        onChange = mmp.changeBoolFunc
+    walkspeed = {
+        default = "normal",
+        type = "string",
+        description = "Walking speed (slow/normal/fast)?",
+        validate = function(v) 
+            return v == "slow" or v == "normal" or v == "fast" 
+        end,
+        onChange = function(name, value)
+            if value == "slow" then
+                mmp.echo("Walking speed set to slow - will pause between moves")
+            elseif value == "fast" then
+                mmp.echo("Walking speed set to fast - will move without waiting for prompts")
+            else
+                mmp.echo("Walking speed set to normal - will wait for prompts between moves")
+            end
+        end
     },
 
     updatemap = {
@@ -100,6 +104,21 @@ mmp.option_definitions = {
                 mmp.echo("Rooms will now be positioned using standard directional offsets (+1)")
             end
         end
+    },
+    
+    autocreateareas = {
+        default = false,
+        type = "boolean",
+        description = "Auto create areas based on GMCP area information when mapping?",
+        games = {"gomud"},
+        onChange = function(name, option)
+            mmp.changeBoolFunc(name, option)
+            if option then
+                mmp.echo("Areas will now be automatically created based on GMCP area information")
+            else
+                mmp.echo("Areas will need to be created manually")
+            end
+        end
     }
 }
 

src/scripts/GoMudMapper/mapping/mmp.mappingnewroom.lua

@@ -1,10 +1,15 @@
 --mmp.mappingNewroom
 
-local function makeroom(oldid, newid, x, y, z)
+local function makeroom(oldid, newid, x, y, z, targetAreaId)
 	assert(x and y and z, "makeroom: need all 3 coordinates")
 	addRoom(newid)
 	setRoomCoordinates(newid, x, y, z)
-	setRoomArea(newid, getRoomArea(oldid))
+	-- Use target area if provided, otherwise inherit from old room
+	if targetAreaId then
+		setRoomArea(newid, targetAreaId)
+	else
+		setRoomArea(newid, getRoomArea(oldid))
+	end
 	local fgr, fgg, fgb = unpack(color_table.red)
 	local bgr, bgg, bgb = unpack(color_table.blue)
 	highlightRoom(newid, fgr, fgg, fgb, bgr, bgg, bgb, 1, 100, 100)
@@ -236,14 +241,45 @@ function mmp.mappingnewroom(_, num)
 										local newY = currentRoomY + (exitData.delta_y * -1)
 										local newZ = currentRoomZ + exitData.delta_z
 
-										s = makeroom(num, id, newX, newY, newZ)
-										setRoomUserData(id, "Area", currentRoomArea)
+										-- Check if exit leads to a different area
+										local targetAreaId = nil
+										if mmp.settings.autocreateareas and exitData.details and exitData.details.leads_to_area then
+											local targetAreaName = exitData.details.leads_to_area
+											-- Try to create the area if it doesn't exist
+											targetAreaId = mmp.areatable[targetAreaName]
+											if not targetAreaId then
+												targetAreaId = addAreaName(targetAreaName)
+												if targetAreaId then
+													mmp.echo(string.format("Created new area: %s (ID: %d)", targetAreaName, targetAreaId))
+													mmp.regenerateareas()
+												end
+											end
+										end
+										
+										s = makeroom(num, id, newX, newY, newZ, targetAreaId)
+										setRoomUserData(id, "Area", exitData.details and exitData.details.leads_to_area or currentRoomArea)
 									else
 										-- Use standard directional positioning (+1 in direction)
+										-- Check if exit leads to a different area
+										local targetAreaId = nil
+										if mmp.settings.autocreateareas and exitData.details and exitData.details.leads_to_area then
+											local targetAreaName = exitData.details.leads_to_area
+											-- Try to create the area if it doesn't exist
+											targetAreaId = mmp.areatable[targetAreaName]
+											if not targetAreaId then
+												targetAreaId = addAreaName(targetAreaName)
+												if targetAreaId then
+													mmp.echo(string.format("Created new area: %s (ID: %d)", targetAreaName, targetAreaId))
+													mmp.regenerateareas()
+												end
+											end
+										end
+										
 										s = makeroom(
 											num,
 											id,
-											getshiftedcoords(exit, getRoomCoordinates(num))
+											getshiftedcoords(exit, getRoomCoordinates(num)),
+											targetAreaId
 										)
 									end
 								else

src/scripts/GoMudMapper/mapping/mmp.roomArea.lua

@@ -0,0 +1,44 @@
+function mmp.roomArea(otherroom, name, exact)
+  local id, fname, ma
+  if tonumber(name) then
+    id = tonumber(name);
+    fname = mmp.areatabler[id]
+  else
+    id, fname, ma = mmp.findAreaID(name, exact)
+  end
+  if otherroom ~= "" and not mmp.roomexists(otherroom) then
+    mmp.echo("Room id " .. otherroom .. " doesn't seem to exist.")
+    return
+  elseif otherroom == "" and not mmp.roomexists(mmp.currentroom) then
+    mmp.echo("Don't know where we are at the moment.")
+    return
+  end
+  otherroom = otherroom ~= "" and otherroom or mmp.currentroom
+  if id then
+    setRoomArea(otherroom, id)
+    mmp.echo(
+      string.format(
+        "Moved %s to %s (%d).",
+        (getRoomName(otherroom) ~= "" and getRoomName(otherroom) or "''"),
+        fname,
+        id
+      )
+    )
+    centerview(otherroom)
+  elseif next(ma) then
+    mmp.echo("Into which area exactly would you like to move the room?")
+    fg("DimGrey")
+    for _, name in ipairs(ma) do
+      echo("  ")
+      setUnderline(true)
+      echoLink(
+        name, [[mmp.roomArea('', "]] .. name .. [[", true)]], "Move the room to " .. name, true
+      )
+      setUnderline(false)
+      echo("\n")
+    end
+    resetFormat()
+  else
+    mmp.echo("Don't know of that area.")
+  end
+end

src/scripts/GoMudMapper/mapping/scripts.json

@@ -62,5 +62,11 @@
         "eventHandlerList": ["sysExitEvent"],
         "script": "",
         "isFolder": "no"
+    },
+    {
+        "name": "mmp.roomArea",
+        "isActive": "yes",
+        "script": "",
+        "isFolder": "no"
     }
 ]

src/scripts/GoMudMapper/navigation/mmp.speedwalking.lua

@@ -137,16 +137,15 @@ function mmp.setmovetimer(time, ignoreLatency)
 	if mmp.movetimer then
 		killTimer(mmp.movetimer)
 	end
-	if mmp.settings.slowwalk and not mmp.hasty then
+	-- Handle walk speed settings
+	if mmp.settings.walkspeed == "slow" and not mmp.hasty then
 		return
-	end
-
-	-- Skip timer for fastwalk mode
-	if mmp.settings.fastwalk then
+	elseif mmp.settings.walkspeed == "fast" then
+		-- Skip timer for fast mode
 		return
 	end
 
-	-- Normal timer logic for regular walking
+	-- Normal timer logic for normal walking
 	local laglevel = mmp.settings.laglevel or 1
 	time = time or mmp.lagtable[laglevel].time
 	local latency = ignoreLatency and 0 or getNetworkLatency()
@@ -189,9 +188,9 @@ function mmp.move()
 		cmd = mmp.speedWalkDir[mmp.speedWalkCounter]
 	end
 	cmd = cmd or ""
-	-- In fastwalk mode, don't set a timer - just send the command
+	-- In fast mode, don't set a timer - just send the command
 	-- The next GMCP room event will trigger the next move
-	if not mmp.settings.fastwalk then
+	if mmp.settings.walkspeed ~= "fast" then
 		-- timeout before loadstring, so it can set its own if it would like to.
 		mmp.setmovetimer()
 	end
@@ -297,8 +296,10 @@ function mmp.stop()
 	--if mmp.movetimer then killTimer( mmp.movetimer ) end
 	mmp.autowalking = false
 	-- clear all the temps we've got
-	for trigger, ID in pairs(mmp.specials) do
-		killTrigger(ID)
+	if mmp.specials then
+		for trigger, ID in pairs(mmp.specials) do
+			killTrigger(ID)
+		end
 	end
 	mmp.specials = {}
 	mmp.echo("Stopped walking.")
@@ -536,7 +537,7 @@ function mmp.speedwalking(event, num)
 			mmp.autowalking = false
 		else
 			-- For faster movement, call mmp.move directly instead of waiting for prompt
-			if mmp.settings.fastwalk then
+			if mmp.settings.walkspeed == "fast" then
 				mmp.move()
 			else
 				tempPromptTrigger(mmp.move, 1)
@@ -608,8 +609,8 @@ function doSpeedWalk(dashtype)
 		mmp.speedWalkCounter = 1
 		if mmp.canmove() then
 			mmp.hasty = true
-			if mmp.settings.fastwalk then
-				-- In fastwalk mode, send the first command immediately
+			if mmp.settings.walkspeed == "fast" then
+				-- In fast mode, send the first command immediately
 				mmp.move()
 			else
 				mmp.setmovetimer(0.1, true)
@@ -623,9 +624,15 @@ function doSpeedWalk(dashtype)
 end
 
 function mmp.failpath()
-	if mmp.movetimer then
+	if mmp.speedWalkWatch then
 		local walktime = stopStopWatch(mmp.speedWalkWatch)
-		mmp.echo(string.format("Can't continue further! Took us %.1fs to get here.\n", walktime))
+		if walktime then
+			mmp.echo(string.format("Can't continue further! Took us %.1fs to get here.\n", walktime))
+		else
+			mmp.echo("Can't continue further!")
+		end
+	else
+		mmp.echo("Can't continue further!")
 	end
 	mmp.autowalking = false
 	mmp.speedWalkPath = {}