Skip to content

Commit 48779d7

Browse files
committed
Custom skills above 10th should use the right addition value
Fixes #68
1 parent 1603104 commit 48779d7

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## [2.1.2] - 2025-08-05
9+
10+
### Fixed
11+
- Custom skills after the 10th will now add their own advance value
12+
813
## [2.1.1] - 2025-04-30
914

1015
### Fixed

js/app.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ document.addEventListener("DOMContentLoaded", (event) => {
220220
// Store custom skill base characteristic and update related output
221221
function handleCharacSelect(event) {
222222
const outputs = event.target.closest("tr").querySelectorAll("output");
223-
const rowId = event.target.id.slice(-1)
223+
const rowId = event.target.closest("tr").dataset.number;
224224
if (!event.target.value) {
225225
outputs.forEach((output) => (output.value = ""));
226226
return;
@@ -330,13 +330,16 @@ document.addEventListener("DOMContentLoaded", (event) => {
330330
const template = document.getElementById(`${type}-row`);
331331
const clone = template.content.cloneNode(true);
332332

333+
const row = clone.querySelector("tr");
333334
const inputs = clone.querySelectorAll("input, output");
334335
const selects = clone.querySelectorAll("select");
335336
const contentEditable = clone.querySelectorAll("[contentEditable]");
336337
const labels = clone.querySelectorAll("label");
337338
const highlight = clone.querySelector(".highlight-toggle");
338339
const remove = clone.querySelector(".remove");
339340

341+
row.dataset.number = n
342+
340343
inputs.forEach((input) => {
341344
input.name = input.name + n;
342345
input.id = input.id + n;

src/_includes/sheet.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -517,7 +517,7 @@ <h1 class="sr-only">{{ 'h1' | i18n }}</h1>
517517
</tr>
518518
</thead>
519519
<tbody>
520-
<tr>
520+
<tr data-number="0">
521521
<td>
522522
<div class="hl-wrapper">
523523
<div class="hl-wrapper-checkbox">
@@ -571,7 +571,7 @@ <h1 class="sr-only">{{ 'h1' | i18n }}</h1>
571571
</tbody>
572572
</table>
573573
<template id="custom-skill-row">
574-
<tr>
574+
<tr data-number="">
575575
<td>
576576
<div class="hl-wrapper">
577577
<div class="hl-wrapper-checkbox">

0 commit comments

Comments
 (0)