Replace the auto-locking of schemas by an explicit "lockSchemas" parameter

Author: sadortun

spec/DefinedSchemas.spec.js

@@ -530,26 +530,30 @@ describe('DefinedSchemas', () => {
     expect(schema.className).toEqual('Test');
   });
 
-  it('should disable class PUT/POST endpoint when schemas provided to avoid dual source of truth', async () => {
+  it('should disable class PUT/POST endpoint when lockSchemas provided to avoid dual source of truth', async () => {
     await reconfigureServer({
-      migrations: { schemas: [{ className: '_User' }, { className: 'Test' }] },
+      migrations: {
+        lockSchemas: true,
+        schemas: [{ className: '_User' }, { className: 'Test' }],
+      },
     });
-    await reconfigureServer({ migrations: { schemas: [{ className: '_User' }] } });
 
     const schema = await new Parse.Schema('Test').get();
     expect(schema.className).toEqual('Test');
 
     const schemas = await Parse.Schema.all();
-    expect(schemas.length).toEqual(4);
+    expect(schemas.length).toEqual(3);
 
     try {
-      await new Parse.Schema('Test').save();
+      await new Parse.Schema('TheNewTest').save();
+      fail('TheNewTest.save() should have failed');
     } catch (e) {
       expect(e.message).toContain('Cannot perform this operation when schemas options is used.');
     }
 
     try {
       await new Parse.Schema('_User').update();
+      fail('_User.update() should have failed');
     } catch (e) {
       expect(e.message).toContain('Cannot perform this operation when schemas options is used.');
     }

src/Routers/SchemasRouter.js

@@ -36,12 +36,7 @@ function getOneSchema(req) {
 }
 
 const checkIfDefinedSchemasIsUsed = req => {
-  if (
-    req.config &&
-    req.config.migrations &&
-    req.config.migrations.schemas &&
-    req.config.migrations.schemas.length
-  ) {
+  if (req.config && req.config.migrations && req.config.migrations.lockSchemas === true) {
     throw new Parse.Error(
       Parse.Error.OPERATION_FORBIDDEN,
       'Cannot perform this operation when schemas options is used.'

src/SchemaMigrations/Migrations.js

@@ -39,6 +39,7 @@ export interface MigrationsOptions {
   strict: ?boolean;
   deleteExtraFields: ?boolean;
   recreateModifiedFields: ?boolean;
+  lockSchemas: ?boolean;
   /* Callback when server has started and before running schemas migration operations if schemas key provided */
   beforeSchemasMigration: ?() => void | Promise<void>;
 }