Skip to content

Commit 74e4c73

Browse files
committed
fix user pictures and connections
1 parent a1aeeee commit 74e4c73

File tree

11 files changed

+40
-23
lines changed

11 files changed

+40
-23
lines changed

main/scn/app/main.gd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
extends Control
22

3-
const version : String = "1.1"
3+
const version : String = "1.2"
44

55
onready var activities : Control = $Main/Activities
66
onready var topbar : HBoxContainer = $TopBar

main/scn/header/header.tscn

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
[ext_resource path="res://main/res/shaders/round_avatar.tres" type="Material" id=2]
55

66
[node name="Header" type="HBoxContainer"]
7-
margin_right = 116.0
7+
margin_right = 168.0
88
margin_bottom = 60.0
99
size_flags_vertical = 4
1010
__meta__ = {
@@ -24,6 +24,8 @@ stretch_mode = 1
2424
[node name="Name" type="Label" parent="."]
2525
margin_left = 68.0
2626
margin_top = 17.0
27-
margin_right = 116.0
27+
margin_right = 168.0
2828
margin_bottom = 42.0
29+
rect_min_size = Vector2( 100, 0 )
2930
text = "user"
31+
autowrap = true

main/scn/header/interactive/interactive_header.gd

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,16 @@ func load_from_user(user_obj : UsersManager.User):
2727
user_document = user_obj.document
2828
if not user_obj.is_connected("update_picture", self, "set_picture"):
2929
user_obj.connect("update_picture", self, "set_picture")
30+
set_user_id(user_obj.id)
3031
set_picture(user_obj.picture)
3132
set_user_name(user_obj.username)
32-
check_friend(user_obj.id)
33+
check_friend()
3334

3435
func load_from_document(document : FirestoreDocument):
3536
user_document = document
37+
set_user_id(document.doc_name)
3638
set_user_name(document.doc_fields.username)
37-
check_friend(document.doc_name)
39+
check_friend()
3840

3941
func set_picture(picture : ImageTexture):
4042
user_picture = picture
@@ -46,8 +48,10 @@ func set_user_name(_name : String):
4648
user_name = _name
4749
$Name.set_text(_name)
4850

49-
func check_friend(user_id : String) -> bool:
50-
self.user_id = user_id
51+
func set_user_id(_id : String):
52+
user_id = _id
53+
54+
func check_friend() -> bool:
5155
$ConnecBtn.visible = not (user_id == UserData.user_id)
5256
$ConnecBtn.activated = (user_id in UserData.friend_list)
5357
$ConnecBtn.set_text("Connected" if (user_id in UserData.friend_list) else "Conect")
@@ -56,7 +60,7 @@ func check_friend(user_id : String) -> bool:
5660
func _on_ConnecBtn_pressed():
5761
var friend_task : FirestoreTask = RequestsManager.update_friend_list(user_id)
5862
yield(friend_task, "update_document")
59-
if check_friend(user_id):
63+
if check_friend():
6064
emit_signal("connected", user, $ConnecBtn)
6165
else:
6266
emit_signal("disconnect", user)

main/scn/header/interactive/interactive_header.tscn

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,9 @@ stretch_mode = 1
3030
[node name="Name" type="LinkButton" parent="."]
3131
margin_left = 70.0
3232
margin_top = 17.0
33-
margin_right = 118.0
33+
margin_right = 420.0
3434
margin_bottom = 42.0
35+
size_flags_horizontal = 3
3536
size_flags_vertical = 4
3637
text = "user"
3738
underline = 1
@@ -42,7 +43,7 @@ margin_top = 11.0
4243
margin_right = 550.0
4344
margin_bottom = 48.0
4445
rect_min_size = Vector2( 120, 30 )
45-
size_flags_horizontal = 14
46+
size_flags_horizontal = 8
4647
size_flags_vertical = 4
4748
text = "Connect"
4849
icon = ExtResource( 5 )

main/scn/home/home.gd

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,9 @@ func _ready():
5353
friend_list.load_friend_list()
5454

5555
func load_user():
56-
$HomeContainer/Menu/Header/Picture.set_texture(UserData.user_picture)
5756
$HomeContainer/Menu/Header/Name.set_text(UserData.user_name)
57+
if UserData.user_picture != null :
58+
$HomeContainer/Menu/Header/Picture.set_texture(UserData.user_picture)
5859

5960

6061
func animate_Home(display : bool):

main/scn/signin/signin.gd

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,15 +72,17 @@ func _on_SignContainer_logged(login):
7272
Firebase.Auth.save_auth(login)
7373
UserData.user_id = login.localid
7474
UserData.user_email = login.email
75-
Activities.loading( false)
75+
Activities.loading(false)
7676
animate_SignContainer(false)
7777
animate_UpdateProfile(true)
7878
$UpdateProfile.show()
7979
return
8080
var picture_task : StorageTask = RequestsManager.get_profile_picture(user_doc.doc_name)
8181
yield(picture_task,"task_finished")
82-
var user_picture : ImageTexture = Utilities.task2image(picture_task)
83-
Activities.loading( false)
82+
var user_picture : ImageTexture = null
83+
if picture_task.data.size() > 0:
84+
user_picture = Utilities.task2image(picture_task)
85+
Activities.loading(false)
8486
UserData.map_user(user_doc, user_picture)
8587
emit_signal("sign_in")
8688

main/scn/signin/signin.tscn

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -112,15 +112,12 @@ margin_bottom = 372.0
112112
size_flags_horizontal = 3
113113
size_flags_vertical = 3
114114
custom_styles/panel = SubResource( 3 )
115-
automatic_signup = true
116-
anonymous_signup = false
117115

118116
[node name="UpdateProfile" type="PanelContainer" parent="."]
119-
visible = false
120117
margin_left = 377.0
121-
margin_top = 286.0
118+
margin_top = 133.0
122119
margin_right = 647.0
123-
margin_bottom = 314.0
120+
margin_bottom = 466.0
124121
rect_min_size = Vector2( 270, 0 )
125122
size_flags_horizontal = 4
126123
size_flags_vertical = 4

main/scn/users_list/users_list.gd

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ func load_users_list():
2121
if user_document.doc_name == UserData.user_id:
2222
continue
2323
if user_document.doc_name in users_list:
24+
var user_header : InteractiveHeader = find_user(user_document.doc_name)
25+
if user_header != null:
26+
user_header.check_friend()
2427
continue
2528
if UsersManager.has_user(user_document.doc_name):
2629
var user_header : InteractiveHeader = user_header_scene.instance()
@@ -35,6 +38,12 @@ func load_users_list():
3538
user_header.connect("show_user_profile", self, "_on_show_user_profile")
3639
users_list.append(user_document.doc_name)
3740
list_container.show()
41+
42+
func find_user(user_id : String) -> InteractiveHeader:
43+
for header in list_container.get_children():
44+
if header.user_id == user_id :
45+
return header
46+
return null
3847

3948
func _on_show_user_profile(user_id : String, user_name : String):
4049
emit_signal("show_user_profile", user_id, user_name)

main/scripts/posts_manager.gd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ func add_post(id : String, document_task : FirestoreTask = null, image_task : St
7171
func add_post_from_doc(id : String, doc : FirestoreDocument, image_task : StorageTask = null) -> Post:
7272
var post : Post
7373
if image_task == null:
74-
if doc.doc_fields.image != "":
74+
if not doc.doc_fields.image in ["", " "]:
7575
image_task = RequestsManager.get_post_image(doc.doc_fields.user_id, id, doc.doc_fields.image)
7676
post = Post.new(id, null, image_task)
7777
else:

main/scripts/users_manager.gd

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,9 @@ class User:
3838
emit_signal("update_user", self)
3939

4040
func _on_picture_received():
41-
picture = Utilities.task2image(picture_task)
42-
emit_signal("update_picture", picture)
41+
if picture_task.data.size() > 0 :
42+
picture = Utilities.task2image(picture_task)
43+
emit_signal("update_picture", picture)
4344

4445
var users : Array = []
4546

0 commit comments

Comments
 (0)