fixed being able to load a string into a Vector2/Vector2i (#450)

* fixed being able to load a string into a Vector2/Vector2i

* added function has_changes_pending() to documents

Allows you to see if theres any additions or changes in a document awaiting an update to the collection, see #451

---------

Co-authored-by: Marcus Andersson <[email protected]>

Author: xzirox

addons/godot-firebase/Utilities.gd

@@ -81,10 +81,10 @@ class FirebaseTypeConverter extends RefCounted:
 		return float(value)
 
 	func _to_vector2(value):
-		return type_convert(value, TYPE_VECTOR2)
+		return str_to_var(value) as Vector2
 
 	func _to_vector2i(value):
-		return type_convert(value, TYPE_VECTOR2I)
+		return str_to_var(value) as Vector2i
 
 static func from_firebase_type(value):
 	if value == null:

addons/godot-firebase/firestore/firestore_collection.gd

@@ -110,6 +110,8 @@ func update(document : FirestoreDocument) -> FirestoreDocument:
 
 		if temp_transforms != null:
 			result._transforms = temp_transforms
+		
+		document.field_added_or_updated = false
 
 	return result
 

addons/godot-firebase/firestore/firestore_document.gd

@@ -16,6 +16,7 @@ var doc_name : String           # only .name
 var create_time : String        # createTime
 var collection_name : String    # Name of the collection to which it belongs
 var _transforms : FieldTransformArray     # The transforms to apply
+var field_added_or_updated : bool     # true or false if anything has been added or updated since the last update()
 signal changed(changes)
 
 func _init(doc : Dictionary = {}):
@@ -129,7 +130,7 @@ func add_or_update_field(field_path : String, value : Variant) -> void:
 		changes.updated.push_back({ "key" : field_path, "old" : existing_value, "new" : value })
 	else:
 		changes.added.push_back({ "key" : field_path, "new" : value })
-
+	field_added_or_updated = true
 	changed.emit(changes)
 
 func on_snapshot(when_called : Callable, poll_time : float = 1.0) -> FirestoreListener.FirestoreListenerConnection:
@@ -159,6 +160,9 @@ func get_value(property : StringName) -> Variant:
 
 	return null
 
+func has_changes_pending() -> bool:
+	return field_added_or_updated
+
 func _get(property: StringName) -> Variant:
 	return get_value(property)
 
@@ -182,4 +186,4 @@ func _to_string() -> String:
 	return ("doc_name: {doc_name}, \ndata: {data}, \ncreate_time: {create_time}\n").format(
 		{doc_name = self.doc_name,
 		data = document,
-		create_time = self.create_time})
+		create_time = self.create_time})