Skip to content

Commit 338b5b9

Browse files
authored
Better format and static type Desktop Jump (#779)
1 parent ea0f374 commit 338b5b9

File tree

1 file changed

+21
-13
lines changed

1 file changed

+21
-13
lines changed

addons/godot-xr-tools/desktop-support/movement_desktop_jump.gd

Lines changed: 21 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
class_name XRToolsDesktopMovementJump
33
extends XRToolsMovementProvider
44

5-
65
## XR Tools Movement Provider for Jumping
76
##
87
## This script provides jumping mechanics for the player. This script works
@@ -14,28 +13,37 @@ extends XRToolsMovementProvider
1413

1514

1615
## Movement provider order
17-
@export var order : int = 20
16+
@export var order: int = 20
1817

1918
## Button to trigger jump
20-
@export var jump_button_action : String = "ui_accept"
19+
@export var jump_button_action: String = "ui_accept"
2120

2221

23-
# Node references
24-
@onready var xr_start_node = XRTools.find_xr_child(
25-
XRTools.find_xr_ancestor(self,
26-
"*Staging",
27-
"XRToolsStaging"),"StartXR","Node")
22+
## XR start node
23+
@onready var xr_start_node: XRToolsStartXR = XRTools.find_xr_child(
24+
XRTools.find_xr_ancestor(
25+
self,
26+
"*Staging",
27+
"XRToolsStaging",
28+
),
29+
"StartXR",
30+
"Node",
31+
)
2832

2933

30-
# Add support for is_xr_class on XRTools classes
31-
func is_xr_class(xr_name: String) -> bool:
34+
## Add support for is_xr_class on XRTools classes
35+
func is_xr_class(xr_name: String) -> bool:
3236
return xr_name == "XRToolsDesktopMovementJump" or super(xr_name)
3337

3438

35-
# Perform jump movement
36-
func physics_movement(_delta: float, player_body: XRToolsPlayerBody, _disabled: bool):
39+
## Perform jump movement
40+
func physics_movement(
41+
_delta: float,
42+
player_body: XRToolsPlayerBody,
43+
_disabled: bool,
44+
) -> void:
3745
# Skip if the jump controller isn't active
38-
if !player_body.enabled or xr_start_node.is_xr_active():
46+
if not player_body.enabled or xr_start_node.is_xr_active():
3947
return
4048

4149
# Request jump if the button is pressed

0 commit comments

Comments
 (0)