Better format and static type Desktop Direct Move (#772)

Author: mubinulhaque

addons/godot-xr-tools/desktop-support/movement_desktop_direct.gd

@@ -2,7 +2,6 @@
 class_name XRToolsDesktopMovementDirect
 extends XRToolsMovementProvider
 
-
 ## XR Tools Movement Provider for Direct Movement
 ##
 ## This script provides direct movement for the player. This script works
@@ -11,43 +10,74 @@ extends XRToolsMovementProvider
 ## The player may have multiple [XRToolsMovementDirect] nodes attached to
 ## different controllers to provide different types of direct movement.
 
-
 ## Movement provider order
-@export var order : int = 10
+@export var order: int = 10
 
 ## Movement speed
-@export var max_speed : float = 3.0
+@export var max_speed: float = 3.0
+
+## Whether the player can strafe
+@export var strafe: bool = false
+
+## Input action for moving forwards
+@export var input_forward: String = "ui_up"
+
+## Input action for moving backwards
+@export var input_backward: String = "ui_down"
 
-## If true, the player can strafe
-@export var strafe : bool = false
+## Input action for moving left
+@export var input_left: String = "ui_left"
 
-## Input action for movement direction
-@export var input_forward : String = "ui_up"
-@export var input_backward : String = "ui_down"
-@export var input_left : String = "ui_left"
-@export var input_right : String = "ui_right"
+## Input action for moving right
+@export var input_right: String = "ui_right"
 
 
-# XRStart node
-@onready var xr_start_node = XRTools.find_xr_child(
-	XRTools.find_xr_ancestor(self,
-	"*Staging",
-	"XRToolsStaging"),"StartXR","Node")
+## XRStart node
+@onready var xr_start_node: XRToolsStartXR = XRTools.find_xr_child(
+		XRTools.find_xr_ancestor(
+				self,
+				"*Staging",
+				"XRToolsStaging",
+		),
+		"StartXR",
+		"Node",
+)
+
+
+## Find the right [XRToolsDesktopMovementDirect] node.
+##
+## This function searches from the specified node for the right controller
+## [XRToolsDesktopMovementDirect] assuming the node is a sibling of the [XROrigin3D].
+static func find(node: Node) -> XRToolsDesktopMovementDirect:
+	return XRTools.find_xr_child(
+			XRHelpers.get_xr_origin(node),
+			"*",
+			"XRToolsDesktopMovementDirect",
+	) as XRToolsDesktopMovementDirect
 
 
-# Add support for is_xr_class on XRTools classes
-func is_xr_class(xr_name:  String) -> bool:
+## Add support for is_xr_class on XRTools classes
+func is_xr_class(xr_name: String) -> bool:
 	return xr_name == "XRToolsDesktopMovementDirect" or super(xr_name)
 
 
-# Perform jump movement
-func physics_movement(_delta: float, player_body: XRToolsPlayerBody, _disabled: bool):
+## Perform jump movement
+func physics_movement(
+		_delta: float,
+		player_body: XRToolsPlayerBody,
+		_disabled: bool,
+) -> void:
 	# Skip if the controller isn't active
-	if !player_body.enabled or xr_start_node.is_xr_active():
+	if not player_body.enabled or xr_start_node.is_xr_active():
 		return
 
-	#Calculate input vector
-	var input_dir = Input.get_vector(input_left, input_right, input_backward, input_forward)
+	# Calculate input vector
+	var input_dir = Input.get_vector(
+			input_left,
+			input_right,
+			input_backward,
+			input_forward
+	)
 
 	# Apply forwards/backwards ground control
 	player_body.ground_control_velocity.y += input_dir.y * max_speed
@@ -60,13 +90,3 @@ func physics_movement(_delta: float, player_body: XRToolsPlayerBody, _disabled:
 	var length := player_body.ground_control_velocity.length()
 	if length > max_speed:
 		player_body.ground_control_velocity *= max_speed / length
-
-## Find the right [XRToolsDesktopMovementDirect] node.
-##
-## This function searches from the specified node for the right controller
-## [XRToolsDesktopMovementDirect] assuming the node is a sibling of the [XROrigin3D].
-static func find(node : Node) -> XRToolsDesktopMovementDirect:
-	return XRTools.find_xr_child(
-		XRHelpers.get_xr_origin(node),
-		"*",
-		"XRToolsDesktopMovementDirect") as XRToolsDesktopMovementDirect