Fix: Type instability in eqClassById during full_join in addEmptyRC#522
Closed
ChangqingW wants to merge 1 commit intoGoekeLab:develfrom
Closed
Fix: Type instability in eqClassById during full_join in addEmptyRC#522ChangqingW wants to merge 1 commit intoGoekeLab:develfrom
ChangqingW wants to merge 1 commit intoGoekeLab:develfrom
Conversation
Author
|
I had a look and turned out it was probably because one of my test cases has only 1 read. I guess this is a very extreme edge case that doesn't really matter... |
Collaborator
|
Hi @ChangqingW , thanks for the updates! Good to see extreme cases where our code might break. I will close this PR for now. Feel free to re-open it if you find it necessary. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a
BiocParallelerror (specifically adplyr::full_joinincompatible types error) that occurs when aeqClassCounthave only one row.The column
eqClassByIdis normally a list-column, but when there is only one row in the tibble, it gets simplified in to a atomic integer vector, making it incompatible tofull_joinwith theminEquiRCtibble:Added a line to force it into a list column.