Skip to content

Commit 87cc989

Browse files
committed
Comments.
1 parent fdda264 commit 87cc989

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

toil/python/draft.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ def run(self, fileStore):
5757
fastqc_output_path = os.path.join(os.path.abspath(current_working_dir), 'readsone_fastqc.html')
5858
fileStore.exportFile(output_file_id, f'file://{fastqc_output_path}')
5959

60-
return {"fastqc_output_path": output_file_id}
60+
return {"fastqc": output_file_id}
6161

6262

6363
class FastQCtwoCls(Job):
@@ -104,7 +104,7 @@ def run(self, fileStore):
104104
fastqc_output_path = os.path.join(os.path.abspath(current_working_dir), 'readstwo_fastqc.html')
105105
fileStore.exportFile(output_file_id, f'file://{fastqc_output_path}')
106106

107-
return {"fastqc_output_path": output_file_id}
107+
return {"fastqc": output_file_id}
108108

109109

110110
class SalmonIndexCls(Job):
@@ -180,11 +180,9 @@ def run(self, fileStore):
180180
except OSError as e:
181181
if e.errno != errno.EEXIST:
182182
raise
183-
184-
fpath_reads1 = fileStore.readGlobalFile(self.reads1, userPath=os.path.join(tempDir, os.path.basename(self.reads1)))
185183

184+
fpath_reads1 = fileStore.readGlobalFile(self.reads1, userPath=os.path.join(tempDir, os.path.basename(self.reads1)))
186185
fpath_reads2 = fileStore.readGlobalFile(self.reads2, userPath=os.path.join(tempDir, os.path.basename(self.reads2)))
187-
188186
fpath_index = fileStore.readGlobalFile(self.index, userPath=os.path.join(tempDir, os.path.basename(self.index)))
189187

190188

@@ -231,10 +229,10 @@ def run(self, fileStore):
231229
ref_transcriptome_file_id = fileStore.importFile(f'file://{os.path.join(pkg_root, "test_data/transcriptome.fa")}')
232230

233231
fastqc_job_1 = FastQConeCls(reads=reads1_file_id) # this is our root job, which runs first
234-
fastqc_output_report_path = fastqc_job_1.rv("fastqc_res") # "rv" == return value
232+
fastqc_output_report_file_id_1 = fastqc_job_1.rv("fastqc") # "rv" == return value
235233

236234
fastqc_job_2 = FastQCtwoCls(reads=reads2_file_id)
237-
FastQCtwo_fastqc_res = fastqc_job_2.rv("fastqc_res")
235+
fastqc_output_report_file_id_2 = fastqc_job_2.rv("fastqc")
238236
fastqc_job_1.addChild(fastqc_job_2) # fastqc_job_2 will run after our root job
239237

240238
salmon_index_job = SalmonIndexCls(ref_txome=ref_transcriptome_file_id)

0 commit comments

Comments
 (0)