fix: ranked and comp unbans are synced

Author: Golbolco

modules/redis.js

@@ -1369,7 +1369,10 @@ async function cacheUserPermissions(userId) {
   );
   var groups = inGroups.map((inGroup) => inGroup.toJSON().group);
 
-  var bans = await models.Ban.find({ userId: userId }).select("permissions");
+  var bans = await models.Ban.find({
+    userId: userId,
+    $or: [{ expires: 0 }, { expires: { $gt: Date.now() } }],
+  }).select("permissions");
 
   var perms = {};
   var maxRank = user.rank || 0;

routes/game.js

@@ -319,7 +319,7 @@ router.get("/:id/connect", async function (req, res) {
       if (
         userId &&
         game.settings.competitive &&
-        !(await routeUtils.verifyPermission(userId, "playRanked"))
+        !(await routeUtils.verifyPermission(userId, "playCompetitive"))
       ) {
         res.status(500);
         res.send(
@@ -692,15 +692,15 @@ router.post("/host", async function (req, res) {
     }
 
     if (
-        req.body.competitive &&
-        !(await routeUtils.verifyPermission(userId, "playRanked"))
-      ) {
-        res.status(500);
-        res.send(
-          "You are unable to play competitive games. Please contact an admin if this is in error."
-        );
-        return;
-      }
+      req.body.competitive &&
+      !(await routeUtils.verifyPermission(userId, "playCompetitive"))
+    ) {
+      res.status(500);
+      res.send(
+        "You are unable to play competitive games. Please contact an admin if this is in error."
+      );
+      return;
+    }
 
     const user = await redis.getUserInfo(userId);
     if (req.body.ranked) {

routes/mod.js

@@ -530,7 +530,7 @@ router.post("/ban", async (req, res) => {
       chat: ["publicChat", "privateChat"],
       game: ["playGame"],
       ranked: ["playRanked", "playCompetitive"],
-      competitive: ["playRanked", "playCompetitive"],
+      competitive: ["playCompetitive"],
       site: ["signIn"],
     };