Fix deserialization globalization issues, add more xml comments. Should fix #10

Author: Gonkers

samples/ScryfallApi.NetFxExample/Program.cs

@@ -36,7 +36,7 @@ static string DrawCard(Card card)
         {
             const int TitleWidth = 31;
             var cardName = card.Name + new string(' ', TitleWidth);
-            var title = cardName.Substring(0, TitleWidth - 1 - card.ManaCost.Length) + " " + card.ManaCost;
+            var title = cardName.Substring(0, TitleWidth - 1 - (card.ManaCost?.Length ?? 0)) + " " + card.ManaCost;
             var type = (card.TypeLine + new string(' ', TitleWidth)).Substring(0, TitleWidth);
 
             var cardText = SplitOnWidth(card.OracleText, 29);
@@ -73,8 +73,10 @@ static string DrawCard(Card card)
 
         static List<string> SplitOnWidth(string text, int width)
         {
-            var rawLines = text.Split(new[] { "\n" }, StringSplitOptions.None);
             var textLines = new List<string>();
+            if (text is null) return textLines;
+
+            var rawLines = text.Split(new[] { "\n" }, StringSplitOptions.None);
             for (int i = 0; i < rawLines.Length; i++)
             {
                 var line = rawLines[i];

src/ScryfallApi.Client/Apis/Cards.cs

@@ -5,6 +5,7 @@
 
 namespace ScryfallApi.Client.Apis
 {
+    ///<inheritdoc cref="ICards"/>
     public class Cards : ICards
     {
         private readonly BaseRestService _restService;

src/ScryfallApi.Client/Apis/Catalogs.cs

@@ -3,6 +3,7 @@
 
 namespace ScryfallApi.Client.Apis
 {
+    ///<inheritdoc cref="ICatalogs"/>
     public class Catalogs : ICatalogs
     {
         private readonly BaseRestService _restService;

src/ScryfallApi.Client/Apis/ICards.cs

@@ -4,6 +4,10 @@
 
 namespace ScryfallApi.Client.Apis
 {
+    /// <summary>
+    /// APIs for cards. Card objects represent individual Magic: The Gathering cards that players could
+    /// obtain and add to their collection (with a few minor exceptions).
+    /// </summary>
     public interface ICards
     {
         Task<Card> GetRandom();

src/ScryfallApi.Client/Apis/ICatalogs.cs

@@ -2,6 +2,11 @@
 
 namespace ScryfallApi.Client.Apis
 {
+    /// <summary>
+    /// A Catalog object contains an array of Magic datapoints (words, card values, etc). Catalog objects
+    /// are provided by the API as aids for building other Magic software and understanding possible
+    /// values for a field on Card objects.
+    /// </summary>
     public interface ICatalogs
     {
         /// <summary>

src/ScryfallApi.Client/Apis/ISets.cs

@@ -3,6 +3,10 @@
 
 namespace ScryfallApi.Client.Apis
 {
+    /// <summary>
+    /// APIs for card sets. A Set object represents a group of related Magic cards. All Card objects on
+    /// Scryfall belong to exactly one set.
+    /// </summary>
     public interface ISets
     {
         /// <summary>

src/ScryfallApi.Client/Apis/ISymbology.cs

@@ -3,6 +3,10 @@
 
 namespace ScryfallApi.Client.Apis
 {
+    /// <summary>
+    /// APIs for card symbols. A Card Symbol object represents an illustrated symbol that may appear in card’s
+    /// mana cost or Oracle text. Symbols are based on the notation used in the Comprehensive Rules.
+    /// </summary>
     public interface ISymbology
     {
         /// <summary>

src/ScryfallApi.Client/Apis/Sets.cs

@@ -3,6 +3,7 @@
 
 namespace ScryfallApi.Client.Apis
 {
+    ///<inheritdoc cref="ISets"/>
     public class Sets : ISets
     {
         private readonly BaseRestService _restService;

src/ScryfallApi.Client/Apis/Symbology.cs

@@ -3,6 +3,7 @@
 
 namespace ScryfallApi.Client.Apis
 {
+    ///<inheritdoc cref="ISymbology"/>
     public class Symbology : ISymbology
     {
         private readonly BaseRestService _restService;

src/ScryfallApi.Client/IScryfallApiClient.cs

@@ -2,11 +2,23 @@
 
 namespace ScryfallApi.Client
 {
+    /// <summary>
+    /// REST client for retrieving data from https://api.scryfall.com/. This software has no affiliation
+    /// with Scryfall.com
+    /// </summary>
     public interface IScryfallApiClient
     {
+
+        ///<inheritdoc cref="ICards"/>
         ICards Cards { get; }
+
+        ///<inheritdoc cref="ICatalogs"/>
         ICatalogs Catalogs { get; }
+
+        ///<inheritdoc cref="ISets"/>
         ISets Sets { get; }
+
+        ///<inheritdoc cref="ISymbology"/>
         ISymbology Symbology { get; }
     }
 }