Skip to content

Commit 39efa0c

Browse files
Merge branch '25_2' into 25_2_ng_nested_fix
2 parents f502a51 + 3e708e0 commit 39efa0c

File tree

10 files changed

+51
-32
lines changed

10 files changed

+51
-32
lines changed

packages/devextreme/js/__internal/grids/data_grid/m_widget.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import DataGrid from './m_widget_base';
44

55
import './module_not_extended/state_storing';
6-
import './module_not_extended/ai_column_controller';
6+
import './module_not_extended/ai_column';
77
import './module_not_extended/selection';
88
import './module_not_extended/column_chooser';
99
import './grouping/m_grouping';
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
import { AiColumnController } from '@ts/grids/grid_core/ai_column/m_ai_column_controller';
2+
import { AiColumnView } from '@ts/grids/grid_core/ai_column/m_ai_column_view';
3+
4+
import gridCore from '../m_core';
5+
6+
gridCore.registerModule('aiColumn', {
7+
controllers: {
8+
aiColumn: AiColumnController,
9+
},
10+
views: {
11+
aiColumnView: AiColumnView,
12+
},
13+
});

packages/devextreme/js/__internal/grids/data_grid/module_not_extended/ai_column_controller.ts

Lines changed: 0 additions & 5 deletions
This file was deleted.

packages/devextreme/js/__internal/grids/grid_core/ai_column/m_ai_column_controller.ts

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,20 @@
11
/* eslint-disable @typescript-eslint/no-unused-vars */
2-
3-
import type { ColumnsController } from '../columns_controller/m_columns_controller';
42
import type { DataController } from '../data_controller/m_data_controller';
53
import { Controller } from '../m_modules';
6-
import { getAiCommandColumnOptions } from './m_ai_column_controller_utils';
74

85
export class AiColumnController extends Controller {
9-
private columnsController!: ColumnsController;
10-
116
private dataController!: DataController;
127

138
private dataChangedHandler!: (e) => any;
149

1510
public init(): void {
16-
this.columnsController = this.getController('columns');
1711
this.dataController = this.getController('data');
1812

1913
this.dataChangedHandler = this.handleDataChanged.bind(this);
2014
this.dataController.changed.add(this.dataChangedHandler);
2115

2216
this.createAction('onAIColumnRequestCreating');
2317
this.createAction('onAIColumnResponseReceived');
24-
25-
this.addAiCommandColumn();
2618
}
2719

2820
private createAIColumnRequest() {
@@ -35,10 +27,6 @@ export class AiColumnController extends Controller {
3527
this.executeAction('onAIColumnResponseReceived', options);
3628
}
3729

38-
private addAiCommandColumn(): void {
39-
this.columnsController.addCommandColumn(getAiCommandColumnOptions());
40-
}
41-
4230
private handleDataChanged(e) {
4331

4432
}
@@ -83,9 +71,3 @@ export class AiColumnController extends Controller {
8371
this.dataController.changed.remove(this.dataChangedHandler);
8472
}
8573
}
86-
87-
export const aiColumnControllerModule = {
88-
controllers: {
89-
aiColumn: AiColumnController,
90-
},
91-
};
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
import type { ColumnsController } from '../columns_controller/m_columns_controller';
2+
import { View } from '../m_modules';
3+
import type { AiColumnController } from './m_ai_column_controller';
4+
import { getAiCommandColumnOptions } from './m_ai_column_controller_utils';
5+
6+
export class AiColumnView extends View {
7+
private columnsController!: ColumnsController;
8+
9+
private aiColumnController!: AiColumnController;
10+
11+
private addAiCommandColumn(): void {
12+
this.columnsController.addCommandColumn(getAiCommandColumnOptions());
13+
}
14+
15+
public init(): void {
16+
this.columnsController = this.getController('columns');
17+
this.aiColumnController = this.getController('aiColumn');
18+
this.addAiCommandColumn();
19+
}
20+
}

packages/devextreme/js/__internal/grids/grid_core/m_types.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/* eslint-disable spellcheck/spell-checker */
2-
/* eslint-disable max-classes-per-file */
2+
33
import type { GridBase, GridBaseOptions, SelectionBase } from '@js/common/grids';
44
import type { Component } from '@js/core/component';
55
import type { PropertyType } from '@js/core/index';
@@ -221,6 +221,7 @@ export interface Views {
221221
gridView: import('./views/m_grid_view').GridView;
222222
filterBuilderView: import('./filter/m_filter_builder').FilterBuilderView;
223223
filterPanelView: import('./filter/m_filter_panel').FilterPanelView;
224+
aiColumnView: import('./ai_column/m_ai_column_view').AiColumnView;
224225
}
225226

226227
export interface EditingControllerRequired {

packages/devextreme/js/__internal/grids/grid_core/views/m_grid_view.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ const GROUP_ROW_SELECTOR = 'tr.dx-group-row';
3434

3535
const HIDDEN_COLUMNS_WIDTH = 'adaptiveHidden';
3636

37-
const VIEW_NAMES = ['columnsSeparatorView', 'blockSeparatorView', 'trackerView', 'headerPanel', 'columnHeadersView', 'rowsView', 'footerView', 'columnChooserView', 'filterPanelView', 'pagerView', 'draggingHeaderView', 'contextMenuView', 'errorView', 'headerFilterView', 'filterBuilderView'];
37+
const VIEW_NAMES = ['columnsSeparatorView', 'blockSeparatorView', 'trackerView', 'headerPanel', 'columnHeadersView', 'rowsView', 'footerView', 'columnChooserView', 'filterPanelView', 'pagerView', 'draggingHeaderView', 'contextMenuView', 'errorView', 'headerFilterView', 'filterBuilderView', 'aiColumnView'];
3838

3939
const E2E_ATTRIBUTES = {
4040
a11yStatusContainer: 'e2e-a11y-general-status-container',

packages/devextreme/js/__internal/grids/tree_list/m_widget.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import TreeList from './m_widget_base';
44

55
import './m_state_storing';
6-
import './module_not_extended/ai_column_controller';
6+
import './module_not_extended/ai_column';
77
import './module_not_extended/column_chooser';
88
import './m_master_detail';
99
import './editing/m_editing';
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
import { AiColumnController } from '@ts/grids/grid_core/ai_column/m_ai_column_controller';
2+
import { AiColumnView } from '@ts/grids/grid_core/ai_column/m_ai_column_view';
3+
4+
import gridCore from '../m_core';
5+
6+
gridCore.registerModule('aiColumn', {
7+
controllers: {
8+
aiColumn: AiColumnController,
9+
},
10+
views: {
11+
aiColumnView: AiColumnView,
12+
},
13+
});

packages/devextreme/js/__internal/grids/tree_list/module_not_extended/ai_column_controller.ts

Lines changed: 0 additions & 5 deletions
This file was deleted.

0 commit comments

Comments
 (0)