WIP. check test for click subscription in events_engine (T1307313)"

This reverts commit d0d18c3.

Author: GoodDayForSurf

packages/devextreme/testing/tests/DevExpress.ui.events/event_nodes_disposing.tests.js

@@ -1,6 +1,8 @@
 import eventsEngine from 'common/core/events/core/events_engine';
-import domAdapter from '__internal/core/m_dom_adapter';
-import { name as clickEventName } from 'common/core/events/click';
+import {
+    subscribeNodesDisposing,
+    unsubscribeNodesDisposing,
+} from '__internal/events/utils/m_event_nodes_disposing';
 
 QUnit.testStart(function() {
     const markup = '<button id="test-element">Test</button>';
@@ -10,48 +12,50 @@ QUnit.testStart(function() {
     }
 });
 
-QUnit.module('event nodes disposing', {
-    afterEach: function() {
-        const document = domAdapter.getDocument();
-        eventsEngine.off(document, clickEventName);
-    }
-});
+QUnit.module('event nodes disposing');
 
-QUnit.test('should not leak memory when subscribing to dxclick on document and clicking elements', function(assert) {
-    const done = assert.async();
+QUnit.test('should not leave extra handlers in elementDataMap when using subscribeNodesDisposing and unsubscribeNodesDisposing for click on document', function(assert) {
+    const clickEventName = 'click';
     const testElement = document.getElementById('test-element');
 
-    eventsEngine.on(document, clickEventName, () => {});
-
-    if(typeof globalThis !== 'undefined' && typeof globalThis.gc === 'function') {
-        globalThis.gc();
-    }
-
-    const initialMemory = performance.memory.usedJSHeapSize;
-
-    let i = 0;
-
-    const interval = setInterval(() => {
-        testElement.click();
-        i++;
-
-        if(i > 99) {
-            setTimeout(() => {
-                if(typeof globalThis !== 'undefined' && typeof globalThis.gc === 'function') {
-                    globalThis.gc();
-                }
-
-                const finalMemory = performance.memory.usedJSHeapSize;
-                const memoryDiff = finalMemory - initialMemory;
-
-                assert.ok(
-                    memoryDiff <= 0,
-                    `Memory should not leak. Memory diff: ${memoryDiff}B`
-                );
-                done();
-            }, 50);
-
-            clearInterval(interval);
-        }
-    }, 50);
+    // Get initial state of handleObjects for click event on document
+    const initialElementData = eventsEngine.elementDataMap.get(document);
+    const initialHandleObjectsCount = initialElementData && initialElementData[clickEventName]
+        ? initialElementData[clickEventName].handleObjects.length
+        : 0;
+
+    // Create a click event by triggering a click
+    const clickEvent = eventsEngine.Event('click', {
+        target: testElement,
+        currentTarget: document,
+        delegateTarget: document.body
+    });
+
+    // Callback for subscribeNodesDisposing
+    const callback = function() {};
+
+    // Subscribe to nodes disposing using the click event
+    const subscriptionData = subscribeNodesDisposing(clickEvent, callback);
+
+    // Get handleObjects count after subscribe
+    const afterSubscribeElementData = eventsEngine.elementDataMap.get(document);
+    const afterSubscribeHandleObjectsCount = afterSubscribeElementData && afterSubscribeElementData[clickEventName]
+        ? afterSubscribeElementData[clickEventName].handleObjects.length
+        : 0;
+
+    // Unsubscribe
+    unsubscribeNodesDisposing(clickEvent, callback, subscriptionData.nodes);
+
+    // Get final handleObjects count after unsubscribe
+    const finalElementData = eventsEngine.elementDataMap.get(document);
+    const finalHandleObjectsCount = finalElementData && finalElementData[clickEventName]
+        ? finalElementData[clickEventName].handleObjects.length
+        : 0;
+
+    // Verify that handleObjects count for click event on document hasn't increased
+    assert.equal(
+        finalHandleObjectsCount,
+        initialHandleObjectsCount,
+        `HandleObjects count should return to initial state. Initial: ${initialHandleObjectsCount}, Final: ${finalHandleObjectsCount}`
+    );
 });

packages/devextreme/testing/tests/DevExpress.ui.events/eventsEngine.tests.js

@@ -568,7 +568,7 @@ QUnit.test('removeEventListener should not be called if native handler is not ex
     delListener.restore();
 });
 
-QUnit.module('Memory bugs');
+QUnit.module('Memory');
 
 QUnit.test('removing subscriptions should remove data from elementDataMap', function(assert) {
     const div = document.createElement('div');
@@ -591,32 +591,6 @@ QUnit.test('removing subscriptions should not remove data from elementDataMap if
     assert.equal(eventsEngine.elementDataMap.has(div), hasData);
 });
 
-QUnit.test('should not leak memory when subscribing on document and clicking elements (T1307313)', function(assert) {
-    const clickEventName = 'dxclick';
-    const fixture = document.getElementById('qunit-fixture');
-
-    fixture.innerHTML = '<button id="test-element">Test</button>';
-
-    const testElement = document.getElementById('test-element');
-
-    eventsEngine.on(document, clickEventName, () => {});
-
-    for(let i = 0; i < 100; i++) {
-        testElement.click();
-    }
-
-    const eventData = eventsEngine.elementDataMap.get(document);
-
-    const count = Object.keys(eventData).reduce((res, key) => res + eventData[key].handleObjects?.length, 0);
-
-    assert.ok(
-        eventData?.length <= 5,
-        `Memory should not leak. Element data: ${count}, ${Object.keys(eventData)}, ${eventsEngine.elementDataMap.size}`
-    );
-
-    eventsEngine.off(document);
-});
-
 QUnit.module('Strategy');
 
 QUnit.test('it should be possible to set only one method for strategy', function(assert) {