Skip to content

Commit ae8e4e8

Browse files
Merge branch '25_2' into 25_2_demos_vue_ts_scheduler
2 parents 5d18af4 + 34efe1c commit ae8e4e8

File tree

3 files changed

+53
-58
lines changed

3 files changed

+53
-58
lines changed

.github/workflows/qunit_tests-additional-renovation.yml

Lines changed: 0 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -72,58 +72,6 @@ jobs:
7272
path: packages/devextreme/artifacts.zip
7373
retention-days: 1
7474

75-
qunit-tests-mobile-and-shadow-dom:
76-
needs: build
77-
runs-on: devextreme-shr2
78-
name: ${{ matrix.constel }}-${{ matrix.kind }}
79-
timeout-minutes: 25
80-
strategy:
81-
fail-fast: false
82-
matrix:
83-
constel: [
84-
'ui',
85-
'ui.widgets(1/3)',
86-
'ui.widgets(2/3)',
87-
'ui.widgets(3/3)',
88-
'ui.editors(1/2)',
89-
'ui.editors(2/2)',
90-
'ui.htmlEditor',
91-
'ui.grid(1/4)',
92-
'ui.grid(2/4)',
93-
'ui.grid(3/4)',
94-
'ui.grid(4/4)',
95-
'ui.scheduler(1/3)',
96-
'ui.scheduler(2/3)',
97-
'ui.scheduler(3/3)',
98-
'viz'
99-
]
100-
kind: [ 'shadow-dom', 'ios10', 'android6' ]
101-
include:
102-
- kind: 'shadow-dom'
103-
userAgent: ''
104-
useShadowDom: true
105-
- kind: 'ios10'
106-
userAgent: 'ios10'
107-
- kind: 'android6'
108-
userAgent: 'android6'
109-
useJQuery: true
110-
111-
steps:
112-
- name: Get sources
113-
uses: actions/checkout@v4
114-
115-
- name: Run QUnit tests
116-
uses: ./.github/actions/run-qunit-tests
117-
with:
118-
name: ${{ matrix.constel }}-${{ matrix.kind }}
119-
constel: ${{ matrix.constel }}
120-
browser: 'chrome'
121-
useJQuery: ${{ matrix.useJquery || 'false' }}
122-
userAgent: ${{ matrix.userAgent }}
123-
useShadowDom: ${{ matrix.useShadowDom }}
124-
headless: 'true'
125-
useCsp: 'true'
126-
12775
qunit-tests-firefox:
12876
needs: build
12977
runs-on: devextreme-shr2
@@ -190,7 +138,6 @@ jobs:
190138
name: Send notifications
191139
needs: [
192140
build,
193-
qunit-tests-mobile-and-shadow-dom,
194141
qunit-tests-firefox,
195142
]
196143
if: github.event_name != 'pull_request' && contains(needs.*.result, 'failure')

.github/workflows/qunit_tests.yml

Lines changed: 44 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,10 +121,53 @@ jobs:
121121
useJQuery: ${{ matrix.useJQuery }}
122122
useCsp: ${{ matrix.CSP }}
123123

124+
qunit-tests-shadow-dom:
125+
needs: build
126+
runs-on: devextreme-shr2
127+
name: ${{ matrix.constel }}-shadow-dom
128+
timeout-minutes: 25
129+
strategy:
130+
fail-fast: false
131+
matrix:
132+
constel: [
133+
'ui',
134+
'ui.widgets(1/3)',
135+
'ui.widgets(2/3)',
136+
'ui.widgets(3/3)',
137+
'ui.editors(1/2)',
138+
'ui.editors(2/2)',
139+
'ui.htmlEditor',
140+
'ui.grid(1/4)',
141+
'ui.grid(2/4)',
142+
'ui.grid(3/4)',
143+
'ui.grid(4/4)',
144+
'ui.scheduler(1/3)',
145+
'ui.scheduler(2/3)',
146+
'ui.scheduler(3/3)',
147+
'viz'
148+
]
149+
150+
steps:
151+
- name: Get sources
152+
uses: actions/checkout@v4
153+
154+
- name: Run QUnit tests
155+
uses: ./.github/actions/run-qunit-tests
156+
with:
157+
name: ${{ matrix.constel }}-shadow-dom
158+
constel: ${{ matrix.constel }}
159+
useJQuery: 'true'
160+
useShadowDom: 'true'
161+
useCsp: 'true'
162+
124163
notify:
125164
runs-on: devextreme-shr2
126165
name: Send notifications
127-
needs: [build, qunit-tests]
166+
needs: [
167+
build,
168+
qunit-tests-shadow-dom,
169+
qunit-tests,
170+
]
128171
if: github.event_name != 'pull_request' && contains(needs.*.result, 'failure')
129172

130173
steps:

packages/devextreme/testing/tests/DevExpress.ui.widgets/ganttParts/milestone.tests.js

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ QUnit.module('Milestone', moduleConfig, () => {
6363

6464
test('custom template, custom html', function(assert) {
6565
const customHtml = $(document.createElement('div')).text('milestone');
66-
const customTaskFunction = (item, container) => {
66+
const customTaskFunction = (item, _) => {
6767
if(item.isMilestone) {
6868
return customHtml.text();
6969
}
@@ -78,7 +78,7 @@ QUnit.module('Milestone', moduleConfig, () => {
7878

7979
test('custom template, custom html + task html', function(assert) {
8080
const customHtml = $(document.createElement('div')).text('milestone');
81-
const customTaskFunction = (item, container) => {
81+
const customTaskFunction = (item, _) => {
8282
if(item.isMilestone) {
8383
$(item.taskHTML[1].cloneNode(true)).appendTo(customHtml);
8484
return customHtml.html();
@@ -107,7 +107,12 @@ QUnit.module('Milestone', moduleConfig, () => {
107107
assert.false(children.eq(0).hasClass(Consts.TASK_TITLE_SELECTOR), 'child is not task title');
108108
});
109109

110-
QUnit.skipInShadowDomMode('position is correctly calculated', function(assert) {
110+
QUnit.test('position is correctly calculated', function(assert) {
111+
if(QUnit.urlParams['shadowDom']) {
112+
assert.ok(true);
113+
return;
114+
}
115+
111116
const { platform } = devices.real();
112117
if(['android', 'ios'].includes(platform)) {
113118
assert.expect(0);
@@ -118,7 +123,7 @@ QUnit.module('Milestone', moduleConfig, () => {
118123
{ 'id': 2, 'parentId': 1, 'title': 'Milestone 1', 'start': new Date('2019-02-21'), 'end': new Date('2019-02-21'), 'progress': 0 },
119124
{ 'id': 3, 'parentId': 2, 'title': 'Milestone 2', 'start': new Date('2019-02-21'), 'end': new Date('2019-02-21'), 'progress': 0 },
120125
];
121-
const customTaskFunction = (item, container) => {
126+
const customTaskFunction = (item, _) => {
122127
if(item.isMilestone) {
123128
const style = item.taskData.id === 2 ? 'width: 10px; height: 10px;' : 'width: 100px; height: 50px;';
124129
return $(document.createElement('div')).attr('style', style);

0 commit comments

Comments
 (0)