fix: Fix Launch screen constraints, unify all binding calls in providers

Author: DominikPetho

Sample/LaunchScreen.storyboard

@@ -3,7 +3,7 @@
     <device id="retina6_1" orientation="portrait" appearance="light"/>
     <dependencies>
         <deployment identifier="iOS"/>
-        <plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="17126"/>
+        <plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="17125"/>
         <capability name="Safe area layout guides" minToolsVersion="9.0"/>
         <capability name="System colors in document resources" minToolsVersion="11.0"/>
         <capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
@@ -33,16 +33,19 @@
                         <rect key="frame" x="0.0" y="0.0" width="414" height="896"/>
                         <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                         <subviews>
-                            <label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" fixedFrame="YES" text="GRProvider" textAlignment="natural" lineBreakMode="tailTruncation" baselineAdjustment="alignBaselines" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="Px6-L0-JnI">
-                                <rect key="frame" x="122" y="429" width="170" height="39"/>
-                                <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMaxY="YES"/>
+                            <label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="GRProvider" textAlignment="natural" lineBreakMode="tailTruncation" baselineAdjustment="alignBaselines" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="Px6-L0-JnI">
+                                <rect key="frame" x="122" y="428.5" width="170" height="39"/>
                                 <fontDescription key="fontDescription" type="boldSystem" pointSize="32"/>
                                 <nil key="textColor"/>
                                 <nil key="highlightedColor"/>
                             </label>
                         </subviews>
                         <viewLayoutGuide key="safeArea" id="6Tk-OE-BBY"/>
                         <color key="backgroundColor" systemColor="systemBackgroundColor"/>
+                        <constraints>
+                            <constraint firstItem="Px6-L0-JnI" firstAttribute="centerX" secondItem="Ze5-6b-2t3" secondAttribute="centerX" id="yUC-P9-88F"/>
+                            <constraint firstItem="Px6-L0-JnI" firstAttribute="centerY" secondItem="Ze5-6b-2t3" secondAttribute="centerY" id="z2X-ul-Lcb"/>
+                        </constraints>
                     </view>
                     <navigationItem key="navigationItem" id="XII-iU-jW1"/>
                 </viewController>

Sample/View Controllers/Collection View/DiffableCollectionProviderViewSampleController.swift

@@ -17,7 +17,7 @@ final class DiffableCollectionProviderViewSampleController: UIViewController {
     @IBOutlet weak var slider: DiffableItemsGeneratorSlider!
     @IBOutlet weak var stepLabel: UILabel!
 
-    fileprivate lazy var provider = GRDiffableCollectionViewProvider<DiffableSection>()
+    fileprivate lazy var provider = GRDiffableCollectionViewProvider<DiffableSection>(collectionView: collectionView)
 
     override func viewDidLoad() {
         super.viewDidLoad()
@@ -48,7 +48,6 @@ final class DiffableCollectionProviderViewSampleController: UIViewController {
             alert.addAction(.init(title: "Cancel", style: .cancel, handler: nil))
             self.present(alert, animated: true)
         }
-        provider.bindCollectionView(collectionView)
     }
 
     func createLayout() -> UICollectionViewLayout {
@@ -124,13 +123,13 @@ final class DiffableCollectionProviderViewSampleController: UIViewController {
             guard let `self` = self else { return }
 
             UIView.animate(withDuration: 0.6) {
-                self.provider.apply(configurator.sections)
+                self.provider.bind(to: self.collectionView, sections: configurator.sections)
             }
             self.stepLabel.text = "Step \(step)/\(steps.count)"
         }
 
         DispatchQueue.main.async { [unowned self] in
-            self.provider.apply(steps[0].sections)
+            self.provider.bind(to: collectionView, sections: steps[0].sections)
             self.stepLabel.text = "Step 1/\(steps.count)"
         }
     }

Sources/GRProvider/Collection View/Diffable/GRDiffableCollectionViewProvider.swift

@@ -23,6 +23,18 @@ open class GRDiffableCollectionViewProvider<Section: Sectionable>: NSObject, UIC
     public typealias DidEndDraggingProvider = (UIScrollView, Bool) -> ()
     public typealias WillEndDraggingProvider = (UIScrollView, CGPoint, UnsafeMutablePointer<CGPoint>) -> ()
 
+    public init(collectionView: UICollectionView) {
+        super.init()
+        
+        dataSource = DataSource(collectionView: collectionView) { (collectionView, indexPath, item) -> UICollectionViewCell? in
+            return self.configureCell?(self, collectionView, indexPath, item)
+        }
+        
+        dataSource?.supplementaryViewProvider = { (collectionView, string, indexPath) -> UICollectionReusableView? in
+            return self.configureSupplementaryElementOfKind?(self, collectionView, indexPath, string)
+        }
+    }
+    
     ///Data source
     private(set) var dataSource: DataSource?
 
@@ -55,16 +67,6 @@ open class GRDiffableCollectionViewProvider<Section: Sectionable>: NSObject, UIC
     public var count: Int {
         return sections.map { $0.items.count }.reduce(0, +)
     }
-    
-    open func bindCollectionView(_ collectionView: UICollectionView) {
-        dataSource = DataSource(collectionView: collectionView) { (collectionView, indexPath, item) -> UICollectionViewCell? in
-            return self.configureCell?(self, collectionView, indexPath, item)
-        }
-        dataSource?.supplementaryViewProvider = { (collectionView, string, indexPath) -> UICollectionReusableView? in
-            return self.configureSupplementaryElementOfKind?(self, collectionView, indexPath, string)
-        }
-        collectionView.delegate = self
-    }
 
     open func collectionView(_ collectionView: UICollectionView, didSelectItemAt indexPath: IndexPath) {
         let selectedItem = sections[indexPath]
@@ -104,8 +106,13 @@ open class GRDiffableCollectionViewProvider<Section: Sectionable>: NSObject, UIC
     // MARK: - Binding
 
     /// Binds items to collection view with default reload animation
-    public func apply(_ sections: [Section], animated: Bool = true, onComplete: @escaping () -> () = {}) {
+    public func bind(to collectionView: UICollectionView,
+                     sections: [Section],
+                     animated: Bool = true,
+                     onComplete: @escaping () -> () = {}) {
         var snapshot = Snapshot()
+                
+        collectionView.delegate = self
 
         snapshot.appendSections(sections)
         for section in sections {

Sources/GRProvider/Table View/Diffable/GRDiffableTableViewProvider.swift

@@ -15,7 +15,6 @@ open class GRDiffableTableViewProvider<Section: Sectionable>: TableViewProvider<
 
     public init(tableView: UITableView) {
         super.init()
-        self.configureCell = configureCell
         self.diffableTableViewProvider = .init(tableView: tableView, cellProvider: { [unowned self] tv, indexPath, item in
             self.configureCell?(self, tv, indexPath, item) ?? UITableViewCell()
         })