Skip to content

Commit 5b476d7

Browse files
Merge pull request #19 from GoodRequest/feature/remove-good-logger
feat: Remove GoodLogger dependency & LoggingPersistenceMonitor
2 parents 3f5e989 + e0ebe4c commit 5b476d7

File tree

5 files changed

+31
-39
lines changed

5 files changed

+31
-39
lines changed

GoodPersistence-Sample/GoodPersistence-Sample.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

Lines changed: 0 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

GoodPersistence-Sample/GoodPersistence-Sample/Application/AppDelegate.swift

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,18 @@ import UIKit
99
import GoodPersistence
1010
import GoodLogger
1111

12+
struct SamplePersistenceMonitor: PersistenceMonitor {
13+
14+
func didReceive(_ monitor: any PersistenceMonitor, error: any Error) {
15+
print("Error received: \(error.localizedDescription)")
16+
}
17+
18+
func didReceive(_ monitor: any PersistenceMonitor, message: String) {
19+
print("Message received: \(message)")
20+
}
21+
22+
}
23+
1224
@main
1325
class AppDelegate: UIResponder, UIApplicationDelegate {
1426

@@ -22,7 +34,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
2234

2335
UINavigationBar.configureAppearance()
2436

25-
GoodPersistence.Configuration.configure(monitors: [LoggingPersistenceMonitor(logger: OSLogLogger())])
37+
GoodPersistence.Configuration.configure(monitors: [SamplePersistenceMonitor()])
2638
AppCoordinator(window: window, di: DI()).start()
2739

2840
return true

Package.swift

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ let package = Package(
1818
// Dependencies declare other packages that this package depends on.
1919
.package(url: "https://github.com/CombineCommunity/CombineExt.git", from: "1.0.0"),
2020
.package(url: "https://github.com/kishikawakatsumi/KeychainAccess.git", from: "4.2.2"),
21-
.package(url: "https://github.com/GoodRequest/GoodLogger.git", from: "1.0.0")
2221
],
2322
targets: [
2423
// Targets are the basic building blocks of a package. A target can define a module or a test suite.
@@ -27,8 +26,7 @@ let package = Package(
2726
name: "GoodPersistence",
2827
dependencies: [
2928
.product(name: "CombineExt", package: "CombineExt"),
30-
.product(name: "KeychainAccess", package: "KeychainAccess"),
31-
.product(name: "GoodLogger", package: "GoodLogger")
29+
.product(name: "KeychainAccess", package: "KeychainAccess")
3230
],
3331
path: "./Sources",
3432
resources: [.copy("PrivacyInfo.xcprivacy")]

README.md

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,5 +58,22 @@ lazy var appStatePublisher = _appState.publisher
5858
.eraseToAnyPublisher()
5959
```
6060

61+
## Logging
62+
```swift
63+
struct SamplePersistenceMonitor: PersistenceMonitor {
64+
65+
func didReceive(_ monitor: any PersistenceMonitor, error: any Error) {
66+
print("Error received: \(error.localizedDescription)")
67+
}
68+
69+
func didReceive(_ monitor: any PersistenceMonitor, message: String) {
70+
print("Message received: \(message)")
71+
}
72+
73+
}
74+
75+
GoodPersistence.Configuration.configure(monitors: [SamplePersistenceMonitor()])
76+
```
77+
6178
## License
6279
GoodPersistence is released under the MIT license. See [LICENSE](LICENSE.md) for details.

Sources/GoodPersistence/LoggingMonitor/LoggingPersistenceMonitor.swift

Lines changed: 0 additions & 26 deletions
This file was deleted.

0 commit comments

Comments
 (0)