Skip to content

Commit 9e8a6a5

Browse files
authored
Merge pull request #11 from GoodRequest/feature/update-logger
Update logger dependency
2 parents 9f36168 + 849d0a0 commit 9e8a6a5

File tree

5 files changed

+43
-13
lines changed

5 files changed

+43
-13
lines changed

GoodReactor-Sample/GoodReactor-Sample.xcodeproj/project.pbxproj

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
099D61732C8472D300B86922 /* GoodNetworking in Frameworks */ = {isa = PBXBuildFile; productRef = 099D61722C8472D300B86922 /* GoodNetworking */; };
1515
099D617F2C84A3CC00B86922 /* RandomNumber.swift in Sources */ = {isa = PBXBuildFile; fileRef = 099D617C2C84A3CC00B86922 /* RandomNumber.swift */; };
1616
099D61802C84A3CC00B86922 /* RNGEndpoint.swift in Sources */ = {isa = PBXBuildFile; fileRef = 099D617D2C84A3CC00B86922 /* RNGEndpoint.swift */; };
17+
3F8C10772D4B7E16000A4CC0 /* GoodCoordinator in Frameworks */ = {isa = PBXBuildFile; productRef = 3F8C10762D4B7E16000A4CC0 /* GoodCoordinator */; };
1718
6B9596242D3E690B0037D874 /* GoodNetworking in Frameworks */ = {isa = PBXBuildFile; productRef = 6B9596232D3E690B0037D874 /* GoodNetworking */; };
1819
EA51F944299424A900B14A7C /* AppDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = EA51F943299424A900B14A7C /* AppDelegate.swift */; };
1920
EA51F94F299424AA00B14A7C /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = EA51F94E299424AA00B14A7C /* Assets.xcassets */; };
@@ -71,6 +72,7 @@
7172
isa = PBXFrameworksBuildPhase;
7273
buildActionMask = 2147483647;
7374
files = (
75+
3F8C10772D4B7E16000A4CC0 /* GoodCoordinator in Frameworks */,
7476
09545AF22CB6705100DC5A61 /* GoodReactor in Frameworks */,
7577
0908A6462C91C0B10035A749 /* GoodCoordinator in Frameworks */,
7678
);
@@ -279,6 +281,7 @@
279281
packageProductDependencies = (
280282
0908A6452C91C0B10035A749 /* GoodCoordinator */,
281283
09545AF12CB6705100DC5A61 /* GoodReactor */,
284+
3F8C10762D4B7E16000A4CC0 /* GoodCoordinator */,
282285
);
283286
productName = "goodreactor-swiftui-sample";
284287
productReference = 092188B02C8CD2A100C6085A /* goodreactor-swiftui-sample.app */;
@@ -335,8 +338,8 @@
335338
);
336339
mainGroup = EA51F937299424A900B14A7C;
337340
packageReferences = (
338-
0908A6442C91C0B10035A749 /* XCLocalSwiftPackageReference "../../GoodCoordinator-iOS" */,
339341
6B9596222D3E690B0037D874 /* XCRemoteSwiftPackageReference "GoodNetworking" */,
342+
3F8C10752D4B7E16000A4CC0 /* XCRemoteSwiftPackageReference "GoodCoordinator-iOS" */,
340343
);
341344
productRefGroup = EA51F941299424A900B14A7C /* Products */;
342345
projectDirPath = "";
@@ -687,14 +690,15 @@
687690
};
688691
/* End XCConfigurationList section */
689692

690-
/* Begin XCLocalSwiftPackageReference section */
691-
0908A6442C91C0B10035A749 /* XCLocalSwiftPackageReference "../../GoodCoordinator-iOS" */ = {
692-
isa = XCLocalSwiftPackageReference;
693-
relativePath = "../../GoodCoordinator-iOS";
694-
};
695-
/* End XCLocalSwiftPackageReference section */
696-
697693
/* Begin XCRemoteSwiftPackageReference section */
694+
3F8C10752D4B7E16000A4CC0 /* XCRemoteSwiftPackageReference "GoodCoordinator-iOS" */ = {
695+
isa = XCRemoteSwiftPackageReference;
696+
repositoryURL = "https://github.com/GoodRequest/GoodCoordinator-iOS";
697+
requirement = {
698+
kind = upToNextMajorVersion;
699+
minimumVersion = 3.0.3;
700+
};
701+
};
698702
6B9596222D3E690B0037D874 /* XCRemoteSwiftPackageReference "GoodNetworking" */ = {
699703
isa = XCRemoteSwiftPackageReference;
700704
repositoryURL = "https://github.com/GoodRequest/GoodNetworking";
@@ -726,6 +730,11 @@
726730
isa = XCSwiftPackageProductDependency;
727731
productName = GoodNetworking;
728732
};
733+
3F8C10762D4B7E16000A4CC0 /* GoodCoordinator */ = {
734+
isa = XCSwiftPackageProductDependency;
735+
package = 3F8C10752D4B7E16000A4CC0 /* XCRemoteSwiftPackageReference "GoodCoordinator-iOS" */;
736+
productName = GoodCoordinator;
737+
};
729738
6B9596232D3E690B0037D874 /* GoodNetworking */ = {
730739
isa = XCSwiftPackageProductDependency;
731740
package = 6B9596222D3E690B0037D874 /* XCRemoteSwiftPackageReference "GoodNetworking" */;

GoodReactor-Sample/GoodReactor-Sample.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

Lines changed: 21 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

GoodReactor-Sample/goodreactor-swiftui-sample/Screens/LoginView/LoginViewModel.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,9 @@ import Observation
4949
// no mutation
5050
return nil
5151
}
52+
53+
case .destination(_):
54+
break
5255
}
5356
}
5457

Package.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ let package = Package(
2323
.package(url: "https://github.com/CombineCommunity/CombineExt.git", from: "1.8.1"),
2424
.package(url: "https://github.com/apple/swift-async-algorithms.git", .upToNextMajor(from: "1.0.0")),
2525
.package(url: "https://github.com/apple/swift-collections.git", .upToNextMajor(from: "1.1.3")),
26-
.package(url: "https://github.com/GoodRequest/GoodLogger.git", .upToNextMajor(from: "1.1.0"))
26+
.package(url: "https://github.com/GoodRequest/GoodLogger.git", .upToNextMajor(from: "1.3.0"))
2727
],
2828
targets: [
2929
.target(

Sources/GoodReactor/Reactor.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -535,7 +535,7 @@ private extension Reactor {
535535
}
536536

537537
private static func _debugLog(message: String) {
538-
logger.log(level: .debug, message: "[GoodReactor] \(Self.name) - \(message)", privacy: .auto)
538+
logger.log(message: "[GoodReactor] \(Self.name) - \(message)", level: .debug)
539539
}
540540

541541
}

0 commit comments

Comments
 (0)