task: Fix samples to pass tests

Author: plajdo

.swiftpm/xcode/xcshareddata/xcschemes/GoodReactor-Package.xcscheme

@@ -35,6 +35,20 @@
                ReferencedContainer = "container:">
             </BuildableReference>
          </BuildActionEntry>
+         <BuildActionEntry
+            buildForTesting = "YES"
+            buildForRunning = "YES"
+            buildForProfiling = "YES"
+            buildForArchiving = "YES"
+            buildForAnalyzing = "YES">
+            <BuildableReference
+               BuildableIdentifier = "primary"
+               BlueprintIdentifier = "LegacyReactor"
+               BuildableName = "LegacyReactor"
+               BlueprintName = "LegacyReactor"
+               ReferencedContainer = "container:">
+            </BuildableReference>
+         </BuildActionEntry>
       </BuildActionEntries>
    </BuildAction>
    <TestAction

Package.swift

@@ -15,8 +15,8 @@ let package = Package(
             targets: ["GoodReactor"]
         ),
         .library(
-            name: "NewReactor",
-            targets: ["NewReactor"]
+            name: "LegacyReactor",
+            targets: ["LegacyReactor"]
         )
     ],
     dependencies: [
@@ -29,30 +29,25 @@ let package = Package(
         .target(
             name: "GoodReactor",
             dependencies: [
-                .product(name: "CombineExt", package: "CombineExt")
+                .product(name: "AsyncAlgorithms", package: "swift-async-algorithms"),
+                .product(name: "Collections", package: "swift-collections"),
+                .product(name: "GoodLogger", package: "GoodLogger")
             ],
             path: "./Sources/GoodReactor",
             swiftSettings: [.swiftLanguageMode(.v6)]
         ),
         .target(
-            name: "NewReactor",
+            name: "LegacyReactor",
             dependencies: [
-                .product(name: "AsyncAlgorithms", package: "swift-async-algorithms"),
-                .product(name: "Collections", package: "swift-collections"),
-                .product(name: "GoodLogger", package: "GoodLogger")
+                .product(name: "CombineExt", package: "CombineExt")
             ],
-            path: "./Sources/NewReactor",
+            path: "./Sources/LegacyReactor",
             swiftSettings: [.swiftLanguageMode(.v6)]
         ),
         .testTarget(
             name: "GoodReactorTests",
             dependencies: ["GoodReactor"],
             swiftSettings: [.swiftLanguageMode(.v6)]
-        ),
-        .testTarget(
-            name: "NewReactorTests",
-            dependencies: ["NewReactor"],
-            swiftSettings: [.swiftLanguageMode(.v6)]
         )
     ]
 )

Sources/NewReactor/AnyTask.swift Sources/GoodReactor/AnyTask.swiftSources/NewReactor/AnyTask.swift renamed to Sources/GoodReactor/AnyTask.swift

@@ -1,5 +1,5 @@
 //
-//  NewReactor.swift
+//  Reactor.swift
 //  GoodReactor
 //
 //  Created by Filip Šašala on 23/08/2024.
@@ -139,6 +139,17 @@ import SwiftUI
     func transform()
 
     #if canImport(Combine)
+    /// Creates subscriptions to external events, that supply events to this Reactor.
+    ///
+    /// You override this function to merge your custom publisher chains with
+    /// a provided event publisher (in parameter).
+    /// ```swift
+    /// func transform(event: AnyPublisher<Event.Kind, Never>) -> AnyPublisher<Event.Kind, Never> {
+    ///     return event
+    ///         .merge(with: myCustomPublisher.map { .mutation(.changeValue($0)) }
+    ///         .eraseToAnyPublisher()
+    /// }
+    /// ```
     func transform(event: AnyPublisher<Event.Kind, Never>) -> AnyPublisher<Event.Kind, Never>
     #endif
 
@@ -203,7 +214,7 @@ public extension Reactor {
 
 public extension Reactor {
 
-    typealias Event = NewReactor.Event<Action, Mutation, Destination>
+    typealias Event = GoodReactor.Event<Action, Mutation, Destination>
 
     static var logger: GoodLogger {
         MapTables.loggers.forceCastedValue(forKey: self, default: makeLogger())
@@ -330,11 +341,30 @@ public extension Reactor {
             }
         }
     }
-    
-    /// <#Description#>
+
+    /// Create a new subscription to external event publisher for current reactor.
+    ///
+    /// The subscription is stored and kept active until the reactor is deallocated
+    /// or a `finish` event is received.
+    ///
+    ///
+    ///
+    /// ## Usage
+    /// ```swift
+    /// func transform() {
+    ///     subscribe {
+    ///         externalValuePublisher
+    ///     } map: {
+    ///         .changeValue($0)
+    ///     }
+    /// }
+    /// ```
     /// - Parameters:
-    ///   - publisherProvider: <#publisherProvider description#>
-    ///   - mapper: <#mapper description#>
+    ///   - publisherProvider: Resolution of an external publisher of any type of value
+    ///   - mapper: Map function mapping received values to this reactor's Mutations.
+    ///
+    /// - important: Call from the `transform` function. Remember to `start()`
+    /// the reactor to properly initalize the subscriptions.
     func subscribe<Value>(
         to publisherProvider: @escaping @autoclosure () -> @Sendable () async -> Publisher<Value>,
         map mapper: @escaping @autoclosure () -> @Sendable (Value) async -> (Mutation)
@@ -468,16 +498,6 @@ public extension Reactor {
 
 }
 
-// MARK: - CustomStringConvertible
-
-//public extension Reactor {
-//
-//    nonisolated var description: String {
-//        String(describing: Self.self)
-//    }
-//
-//}
-
 // MARK: - Migration
 
 public extension Reactor {