Error localization

Author: plajdo

GoodSwiftUI-Sample/GoodSwiftUI-Sample.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

@@ -16,7 +16,7 @@ struct InputFieldSampleView: View {
         case notFilip
         case pinTooShort
 
-        var localizedDescription: String {
+        var errorDescription: String? {
             switch self {
             case .notFilip:
                 "Your name is not Filip"

GoodSwiftUI-Sample/GoodSwiftUI-Sample/Screens/InputFieldSampleView.swift

@@ -23,7 +23,7 @@ let package = Package(
         )
     ],
     dependencies: [
-        .package(url: "https://github.com/goodrequest/goodextensions-ios", .upToNextMajor(from: "2.0.0"))
+        .package(url: "https://github.com/GoodRequest/GoodExtensions-iOS.git", .upToNextMajor(from: "2.0.2"))
     ],
     targets: [
         .target(

Package.resolved

@@ -10,11 +10,7 @@ import GoodExtensions
 
 // MARK: - Validation errors
 
-@MainActor public protocol ValidationError: Error {
-
-    var localizedDescription: String { get }
-
-}
+public protocol ValidationError: LocalizedError {}
 
 public enum InternalValidationError: ValidationError {
 
@@ -23,7 +19,7 @@ public enum InternalValidationError: ValidationError {
     case mismatch
     case external(MainSupplier<String>)
 
-    public var localizedDescription: String {
+    public var errorDescription: String? {
         switch self {
         case .alwaysError:
             "Error"
@@ -35,7 +31,9 @@ public enum InternalValidationError: ValidationError {
             "Elements do not match"
 
         case .external(let description):
-            description()
+            MainActor.assumeIsolated {
+                description()
+            }
         }
     }
 
@@ -74,7 +72,7 @@ public extension Criterion {
             .failWith(error: criterion.error)
     }
 
-    static func external(error: @MainActor @escaping () -> (any Error)?) -> Criterion {
+    static func external(error: @MainActor @escaping () -> (any LocalizedError)?) -> Criterion {
         Criterion { _ in error().isNil }
             .failWith(error: InternalValidationError.external { error()?.localizedDescription ?? " " })
     }

Package.swift

@@ -318,6 +318,10 @@ public struct InputField<LeftView: View, RightView: View>: UIViewRepresentable {
             return syncValidationState(uiViewState: .pending(error: validationError), context: context)
         }
 
+        guard newValidationState != previousValidationState else {
+            return
+        }
+
         changeValidationState(to: newValidationState, uiView: uiView, context: context)
     }
 

Sources/GRInputField/Common/ValidationError.swift

@@ -25,7 +25,7 @@ public typealias ValidityGroup = [UUID: ValidationState]
 
 // MARK: - Validation State
 
-@MainActor public enum ValidationState: Sendable {
+@MainActor public enum ValidationState: Sendable, Equatable {
 
     case valid
     case error(any ValidationError)
@@ -56,4 +56,23 @@ public typealias ValidityGroup = [UUID: ValidationState]
         }
     }
 
+    nonisolated public static func == (lhs: ValidationState, rhs: ValidationState) -> Bool {
+        switch (lhs, rhs) {
+        case (.valid, .valid):
+            return true
+
+        case (.invalid, .invalid):
+            return true
+
+        case (.error(let lhsValidationError), .error(let rhsValidationError)):
+            return lhsValidationError.localizedDescription == rhsValidationError.localizedDescription
+
+        case (.pending(let lhsValidationError), .pending(let rhsValidationError)):
+            return lhsValidationError?.localizedDescription == rhsValidationError?.localizedDescription
+
+        default:
+            return false
+        }
+    }
+
 }