Skip to content

Commit f3efa1b

Browse files
committed
fix(nativeHelm): add HELM_EXPERIMENTAL_OCI=1 to enable OCI support on helm 3.7.x
Set HELM_EXPERIMENTAL_OCI=1 unconditionally in the helm deploy container env vars. This is required for OCI registry support on helm 3.7.x and is a no-op on helm 3.8+ where OCI support became stable.
1 parent 7b998f3 commit f3efa1b

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

src/server/lib/nativeHelm/__tests__/helm.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -527,6 +527,7 @@ describe('Native Helm', () => {
527527
expect(result.env).toEqual([
528528
{ name: 'HELM_CACHE_HOME', value: '/workspace/.helm/cache' },
529529
{ name: 'HELM_CONFIG_HOME', value: '/workspace/.helm/config' },
530+
{ name: 'HELM_EXPERIMENTAL_OCI', value: '1' },
530531
]);
531532
expect(result.command).toEqual(['/bin/sh', '-c']);
532533
expect(result.args).toHaveLength(1);

src/server/lib/nativeHelm/helm.ts

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -92,14 +92,9 @@ export async function createHelmContainer(
9292
name: 'helm-deploy',
9393
image: `${HELM_IMAGE_PREFIX}:${helmVersion}`,
9494
env: [
95-
{
96-
name: 'HELM_CACHE_HOME',
97-
value: '/workspace/.helm/cache',
98-
},
99-
{
100-
name: 'HELM_CONFIG_HOME',
101-
value: '/workspace/.helm/config',
102-
},
95+
{ name: 'HELM_CACHE_HOME', value: '/workspace/.helm/cache' },
96+
{ name: 'HELM_CONFIG_HOME', value: '/workspace/.helm/config' },
97+
{ name: 'HELM_EXPERIMENTAL_OCI', value: '1' },
10398
],
10499
command: ['/bin/sh', '-c'],
105100
args: [script],

0 commit comments

Comments
 (0)