PATHNAME in the report name is blank + assertions aren't be run on all the urls

[jaspritt-hora]

Hello there,
I am generating lighthouse reports for my app with a local setup and the reports are dumped on the filesystem.

I have two questions -

1. When running lhci autorun for multiple urls of the same website, the reports doesn't have the PATHNAME (it is blank) even though it is passed in reportFilenamePattern option.
2. The assertions specified is run on the base url instead on the provided url?

Additional context for Q1:

reportFilenamePattern has the format : %%HOSTNAME%%-%%PATHNAME%%-%%DATETIME%%-report.%%EXTENSION%%

Current behaviour:

Expected behaviour:
The report name should have the following -

localhost-users-<date time>.json/.html
localhost-messages-<date time>.json/.html
localhost-calendar-<date time>.json/.html

What else I am missing here?

Additional context for Q2:

The urls option is passed the following values:
url:[ 'http://localhost:8070/#/en/', 'http://localhost:8070/#/en/users/', 'http://localhost:8070/#/en/calendar/', 'http://localhost:8070/#/en/library/?tab=exercises', 'http://localhost:8070/#/en/facility_assignments/', 'http://localhost:8070/#/en/messages/', 'http://localhost:8070/#/en/settings?tab=risk' ]

Output of the autorun command (Current behaviour):

It says -

Checking assertions against 1 URL(s), 7 total run(s)

Expected behaviour:

It should say -

Checking assertions against 7 URL(s), 1 total run(s) since there are 7 separate urls

Overall information and details:

lighthouserc.js

lhci - v0.9.0
Node - v16

[jaspritt-hora]

@patrickhulce - Can you let me know, what needs to be done here?

[patrickhulce]

Everything here is WAI because the URLs here have no unique pathname, they use the client-side routing hack of #/ so this would require a new feature to support that in the template.

[jaspritt-hora]

@patrickhulce - Thank you for the info. Is there any workaround for this currently?
Additionally, do you have an idea about when this change would be taken up for implementation?

[patrickhulce]

Is there any workaround for this currently?

Not aside from using URLs with an actual pathname.

do you have an idea about when this change would be taken up for implementation?

As soon as you have some free time ;) (just need to add url.hash to

lighthouse-ci/packages/cli/src/upload/upload.js

Line 545 in 75f4bb8

pathname: url.pathname,

)

[jaspritt-hora]

@patrickhulce - Sounds good. I can take up the addition. This is going to be the first time I am contributing to open source; anything apart from the contributing guidelines needed to be kept in mind before working on this feature?

[jaspritt-hora]

@patrickhulce - Can you please create a new release & tag with this change, so that it can be used in the app?

[jaspritt-hora]

@connorjclark - Could you please review the PR and answer the follow up questions above?

[jaspritt-hora]

@connorjclark - Request you to please review the PR and provide your approvals or your comments and complete the other steps in the workflow. So, that we can test this out in our application - as we are actively working on the integration.

Thank you!

[connorjclark]

@jaspritt-hora I suggest you figure out how to utilize your fork more directly. Given the holidays this isn't going to happen on your expected timeline.

[jaspritt-hora]

@connorjclark - Thank you for the update. Will use the fork and test out the change.
Happy holidays!

[jaspritt-hora]

@connorjclark - I have tested my fork and the PR raised for url hash is working flawlessly for filesystem. Can you tell me a ballpark ETA for the new release that would include the PR?