diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7e67ce7ece7b..9b06f4089e87 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -56,7 +56,7 @@ jobs: - run: yarn diff:sample-json - run: yarn diff:flow-sample-json - run: yarn lint - - run: yarn test-lantern + - run: yarn test-legacy-javascript env: # https://github.com/nodejs/node/issues/51555#issuecomment-1974877052 diff --git a/core/scripts/lantern/collect/README.md b/core/scripts/lantern/collect/README.md index 297ab47dbcb7..10f3bbad25b3 100644 --- a/core/scripts/lantern/collect/README.md +++ b/core/scripts/lantern/collect/README.md @@ -41,7 +41,7 @@ DEBUG=1 WPT_KEY=... node --max-old-space-size=4096 collect.js Output will be in `dist/collect-lantern-traces`, and zipped at `dist/collect-lantern-traces.zip`. -Update the zip on Google Drive and `download-traces.sh`. +Update the zip on at http://go/lhsth and any references in `download-traces.sh`. ## Run in GCP diff --git a/core/scripts/lantern/download-traces.sh b/core/scripts/lantern/download-traces.sh index 2a23f6de059b..c69b04d20455 100755 --- a/core/scripts/lantern/download-traces.sh +++ b/core/scripts/lantern/download-traces.sh @@ -25,11 +25,17 @@ if [[ -f lantern-data/site-index-plus-golden-expectations.json ]] && ! [[ "$FORC exit 0 fi + rm -rf lantern-data/ mkdir -p lantern-data/ && cd lantern-data -curl -o golden-lantern-traces.zip -L https://storage.googleapis.com/lh-lantern-data/golden-lantern-traces-$VERSION.zip - -unzip -q golden-lantern-traces.zip -rm golden-lantern-traces.zip echo $VERSION > version + +echo "Manual steps due to data download restrictions:" +echo "open http://go/lhsth " +echo "cd $LH_ROOT_PATH" +echo "download golden-lantern-traces-$VERSION.zip to $LH_ROOT_PATH" +echo "rename to golden-lantern-traces.zip" +echo "unzip it." +echo "then delete the zip". +