Add enums to sort by browser feature support

Author: jcscottiii

lib/gcpspanner/spanneradapters/backend.go

@@ -555,12 +555,13 @@ func (s *Backend) FeaturesSearch(
 }
 
 // TODO: Pass in context to be used by slog.ErrorContext.
+// nolint: gocyclo // WONTFIX. Keep all the cases here so that the exhaustive
+// linter can catch a missing case.
 func getFeatureSearchSortOrder(
 	sortOrder *backend.ListFeaturesParamsSort) gcpspanner.Sortable {
 	if sortOrder == nil {
 		return gcpspanner.NewBaselineStatusSort(false)
 	}
-	// nolint: exhaustive // Remove once we support all the cases.
 	switch *sortOrder {
 	case backend.NameAsc:
 		return gcpspanner.NewFeatureNameSort(true)
@@ -606,6 +607,22 @@ func getFeatureSearchSortOrder(
 		return gcpspanner.NewChromiumUsageSort(true)
 	case backend.ChromiumUsageDesc:
 		return gcpspanner.NewChromiumUsageSort(false)
+	case backend.DesktopAvailabilityChromeAsc:
+		return gcpspanner.NewBrowserFeatureSupportSort(true, string(backend.Chrome))
+	case backend.DesktopAvailabilityChromeDesc:
+		return gcpspanner.NewBrowserFeatureSupportSort(false, string(backend.Chrome))
+	case backend.DesktopAvailabilityEdgeAsc:
+		return gcpspanner.NewBrowserFeatureSupportSort(true, string(backend.Edge))
+	case backend.DesktopAvailabilityEdgeDesc:
+		return gcpspanner.NewBrowserFeatureSupportSort(false, string(backend.Edge))
+	case backend.DesktopAvailabilityFirefoxAsc:
+		return gcpspanner.NewBrowserFeatureSupportSort(true, string(backend.Firefox))
+	case backend.DesktopAvailabilityFirefoxDesc:
+		return gcpspanner.NewBrowserFeatureSupportSort(false, string(backend.Firefox))
+	case backend.DesktopAvailabilitySafariAsc:
+		return gcpspanner.NewBrowserFeatureSupportSort(true, string(backend.Safari))
+	case backend.DesktopAvailabilitySafariDesc:
+		return gcpspanner.NewBrowserFeatureSupportSort(false, string(backend.Safari))
 	}
 
 	// Unknown sort order

lib/gcpspanner/spanneradapters/backend_test.go

@@ -1336,6 +1336,38 @@ func TestGetFeatureSearchSortOrder(t *testing.T) {
 			input: valuePtr(backend.StableSafariDesc),
 			want:  gcpspanner.NewBrowserImplSort(false, "safari", true),
 		},
+		{
+			input: valuePtr(backend.DesktopAvailabilityChromeAsc),
+			want:  gcpspanner.NewBrowserFeatureSupportSort(true, "chrome"),
+		},
+		{
+			input: valuePtr(backend.DesktopAvailabilityChromeDesc),
+			want:  gcpspanner.NewBrowserFeatureSupportSort(false, "chrome"),
+		},
+		{
+			input: valuePtr(backend.DesktopAvailabilityEdgeAsc),
+			want:  gcpspanner.NewBrowserFeatureSupportSort(true, "edge"),
+		},
+		{
+			input: valuePtr(backend.DesktopAvailabilityEdgeDesc),
+			want:  gcpspanner.NewBrowserFeatureSupportSort(false, "edge"),
+		},
+		{
+			input: valuePtr(backend.DesktopAvailabilityFirefoxAsc),
+			want:  gcpspanner.NewBrowserFeatureSupportSort(true, "firefox"),
+		},
+		{
+			input: valuePtr(backend.DesktopAvailabilityFirefoxDesc),
+			want:  gcpspanner.NewBrowserFeatureSupportSort(false, "firefox"),
+		},
+		{
+			input: valuePtr(backend.DesktopAvailabilitySafariAsc),
+			want:  gcpspanner.NewBrowserFeatureSupportSort(true, "safari"),
+		},
+		{
+			input: valuePtr(backend.DesktopAvailabilitySafariDesc),
+			want:  gcpspanner.NewBrowserFeatureSupportSort(false, "safari"),
+		},
 	}
 
 	for _, tt := range sortOrderTests {

openapi/backend/openapi.yaml

@@ -76,6 +76,14 @@ paths:
               - experimental_firefox_desc
               - chromium_usage_asc
               - chromium_usage_desc
+              - desktop_availability_chrome_asc
+              - desktop_availability_chrome_desc
+              - desktop_availability_edge_asc
+              - desktop_availability_edge_desc
+              - desktop_availability_firefox_asc
+              - desktop_availability_firefox_desc
+              - desktop_availability_safari_asc
+              - desktop_availability_safari_desc
       responses:
         '200':
           description: OK