Commit 1ef34c6
committed
fix: Return correct feature evolution data for moved and split features
The primary changes are:
- The `GetMovedWebFeatureDetailsByOriginalFeatureKey` function has been fixed. It was previously returning the internal database ID of the new feature; it now correctly returns the human-readable feature key, as intended.
- The main feature query has been updated to join against a new `SplitWebFeatures` table. The `GET /v1/features` and `GET /v1/features/{feature_id}` endpoints now include an `evolution` object in the response. This object contains `split_off_info` which lists any features that have been split off from the primary feature.
To support this, the following changes were also made:
- The `openapi.yaml` specification has been updated to include the new `evolution` fields in the `Feature` schema.
- The fake data generation process in `util/cmd/load_fake_data` has been significantly enhanced to create more realistic test data for feature evolution, including scenarios for moved, fully split, and partially split features.
- End-to-end tests and snapshots have been updated to reflect the new data structures and the changes in the underlying test data.start
There needs to be some frontend changes. But that will come in a future PR.1 parent 0908131 commit 1ef34c6
File tree
47 files changed
+791
-537
lines changed- e2e/tests
- 404.spec.ts-snapshots
- feature-page.spec.ts-snapshots
- overview-page.spec.ts-snapshots
- stats-page.spec.ts-snapshots
- lib
- gcpspanner
- spanneradapters
- util/cmd/load_fake_data
- workflows/steps/services
- bcd_consumer
- web_feature_consumer
- wpt_consumer
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
47 files changed
+791
-537
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
24 | 27 | | |
25 | | - | |
| 28 | + | |
26 | 29 | | |
27 | 30 | | |
28 | 31 | | |
| |||
35 | 38 | | |
36 | 39 | | |
37 | 40 | | |
38 | | - | |
| 41 | + | |
39 | 42 | | |
40 | 43 | | |
41 | 44 | | |
| |||
71 | 74 | | |
72 | 75 | | |
73 | 76 | | |
74 | | - | |
| 77 | + | |
75 | 78 | | |
76 | 79 | | |
77 | 80 | | |
| |||
84 | 87 | | |
85 | 88 | | |
86 | 89 | | |
87 | | - | |
| 90 | + | |
88 | 91 | | |
89 | 92 | | |
90 | 93 | | |
| |||
131 | 134 | | |
132 | 135 | | |
133 | 136 | | |
134 | | - | |
| 137 | + | |
135 | 138 | | |
136 | 139 | | |
137 | 140 | | |
| |||
0 commit comments