Fix view=test scoring (#1239)

This change is essentially a port of these two PRs:
- web-platform-tests/wpt.fyi#4290
- web-platform-tests/wpt.fyi#4294

The logic to increment TestPass comes from the earlier PRs.
And missing tests should not increment subtest counts or TestPass count.
It should only increment TotalTests by one for a given feature.

Other fixes:
- This also fixes a problem where crashed tests were being counted as passing. The unit test reduced the count for feature6.
- Skip counting subtests if the test file is missing.
- Add pretty printing of the output to help with debugging.

Author: jcscottiii

workflows/steps/services/wpt_consumer/pkg/workflow/score_webfeature.go

@@ -37,6 +37,7 @@ const (
 	WPTStatusCrash              WPTStatusAbbreviation = "C"
 	WPTStatusTimeout            WPTStatusAbbreviation = "T"
 	WPTStatusPreconditionFailed WPTStatusAbbreviation = "PF"
+	WPTStatusEmpty              WPTStatusAbbreviation = ""
 )
 
 // Score calculates web feature metrics from a V2 results summary file.
@@ -90,6 +91,12 @@ func (s ResultsSummaryFileV2) scoreSubtests(
 	if webFeatures, found = (*testToWebFeatures)[test]; !found {
 		return
 	}
+
+	// If the test has missing results, skip it.
+	if isTestMissing(testStatus, numberofSubtests) {
+		return
+	}
+
 	// In the event of a crash, wpt records the incorrect number of subtests (but not tests).
 	// Ignore subtest metrics for now. And mark the web feature as a whole as one to not update the subtest metrics
 	if WPTStatusAbbreviation(testStatus) == WPTStatusCrash {
@@ -147,6 +154,24 @@ func getScoreForFeature(
 	return score
 }
 
+func isPassingViewTest(testStatus string, subtests, total int) bool {
+	return isPassingViewTestStatus(testStatus) &&
+		subtests == total && !isTestMissing(testStatus, total)
+}
+
+func isTestMissing(testStatus string, total int) bool {
+	return WPTStatusAbbreviation(testStatus) == WPTStatusEmpty &&
+		total == 0
+}
+
+func isPassingViewTestStatus(testStatus string) bool {
+	return WPTStatusAbbreviation(testStatus) == WPTStatusOK ||
+		WPTStatusAbbreviation(testStatus) == WPTStatusPass ||
+		// Should handle the status == empty case.
+		// Background: https://github.com/web-platform-tests/wpt.fyi/pull/4290
+		WPTStatusAbbreviation(testStatus) == WPTStatusEmpty
+}
+
 // scoreTest updates web feature metrics for a single test
 // based on provided subtest results and web features data.
 func (s ResultsSummaryFileV2) scoreTest(
@@ -165,16 +190,8 @@ func (s ResultsSummaryFileV2) scoreTest(
 		return
 	}
 	// Calculate the value early so we can re-use for multiple web features.
-	// Logic for zero subtests
-	var countsAsPassing bool
-	if numberofSubtests == 0 {
-		// Determine the appropriate logic based on the status, as done in JavaScript
-		if WPTStatusAbbreviation(testStatus) == WPTStatusOK || WPTStatusAbbreviation(testStatus) == WPTStatusPass {
-			countsAsPassing = true // Treat as passing if status is OK or Pass
-		}
-	} else {
-		countsAsPassing = numberOfSubtestPassing == numberofSubtests
-	}
+	countsAsPassing := isPassingViewTest(testStatus, numberOfSubtestPassing, numberofSubtests)
+
 	for webFeature := range webFeatures {
 		webFeatureScore := getScoreForFeature(webFeature, webFeatureScoreMap)
 		*webFeatureScore.TotalTests++

workflows/steps/services/wpt_consumer/pkg/workflow/score_webfeature_test.go

@@ -99,6 +99,9 @@ func getComplexWebFeaturesData() shared.WebFeaturesData {
 		"dir/tentative/test10.html": {
 			"feature1": nil,
 		},
+		"test11-missing.html": {
+			"feature1": nil,
+		},
 	}
 }
 
@@ -159,6 +162,12 @@ func getComplexSummary() ResultsSummaryFileV2 {
 			Status: string(WPTStatusPass),
 			Counts: []int{111, 111},
 		},
+		// Missing tests should not increment subtest counts or TestPass count.
+		// It should only increment TotalTests by one for a given feature.
+		"test11-missing.html": query.SummaryResult{
+			Status: string(WPTStatusEmpty),
+			Counts: []int{0, 0},
+		},
 	}
 }
 
@@ -189,7 +198,7 @@ func TestScore(t *testing.T) {
 			summary:           getComplexSummary(),
 			expectedOutput: map[string]wptconsumertypes.WPTFeatureMetric{
 				"feature1": {
-					TotalTests:        valuePtr[int64](2),
+					TotalTests:        valuePtr[int64](3),
 					TestPass:          valuePtr[int64](2),
 					TotalSubtests:     valuePtr[int64](101),
 					SubtestPass:       valuePtr[int64](101),
@@ -225,7 +234,7 @@ func TestScore(t *testing.T) {
 				},
 				"feature6": {
 					TotalTests:    valuePtr[int64](5),
-					TestPass:      valuePtr[int64](4),
+					TestPass:      valuePtr[int64](2),
 					TotalSubtests: nil,
 					SubtestPass:   nil,
 					FeatureRunDetails: map[string]interface{}{