Skip to content

Commit 608fa2d

Browse files
authored
Show "Not available" tooltip. (#1134)
* Show "Not available" tooltip. * lint-fix
1 parent 5f7539c commit 608fa2d

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

frontend/src/static/js/components/test/webstatus-overview-cells.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -454,7 +454,7 @@ describe('renderDesktopAvailablity', () => {
454454
const div = el.querySelector('div');
455455
expect(div).to.exist;
456456
expect(div!.getAttribute('class')).to.equal('browser-impl-available');
457-
expect(div!.innerHTML).to.not.include('disabled');
457+
expect(div!.innerHTML).to.include('Since ');
458458
expect(div!.innerHTML).to.include('chrome_24x24.png');
459459
});
460460
it('renders a grayscale icon for an available feature', async () => {
@@ -475,7 +475,7 @@ describe('renderDesktopAvailablity', () => {
475475
const div = el.querySelector('div');
476476
expect(div).to.exist;
477477
expect(div!.getAttribute('class')).to.equal('browser-impl-unavailable');
478-
expect(div!.innerHTML).to.include('disabled');
478+
expect(div!.innerHTML).to.include('Not available');
479479
expect(div!.innerHTML).to.include('chrome_24x24.png');
480480
});
481481
});

frontend/src/static/js/components/webstatus-overview-cells.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,8 +281,9 @@ export const renderDesktopAvailablity: CellRenderer = (
281281
return html`
282282
<div class="browser-impl-${browserImplStatus}">
283283
<sl-tooltip
284-
?disabled=${browserImplVersion === undefined}
285-
content="Since version ${browserImplVersion}"
284+
content=${browserImplVersion
285+
? `Since version ${browserImplVersion}`
286+
: 'Not available'}
286287
>
287288
<img src="/public/img/${browser}_24x24.png" />
288289
</sl-tooltip>

frontend/src/static/js/components/webstatus-overview-table.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ export class WebstatusOverviewTable extends LitElement {
7676
.baseline-date-block {
7777
padding-top: var(--content-padding-quarter);
7878
}
79-
.browser-impl-unavailable {
79+
.browser-impl-unavailable img {
8080
filter: grayscale(1);
8181
opacity: 50%;
8282
}

0 commit comments

Comments
 (0)