fix: Add ON DELETE CASCADE to WebFeatures foreign keys (#1691)

* fix: Add ON DELETE CASCADE to WebFeatures foreign keys

Fixes #513

Previously, deleting a record from the WebFeatures table would fail if it was referenced by other tables.

This change updates all foreign key constraints that reference WebFeatures(ID) to include ON DELETE CASCADE. This ensures that when a feature is deleted, all its associated data in other tables is automatically removed.

The constraints have also been given explicit names to improve schema manageability. An integration test has been added to verify the cascade behavior across all related tables and prevent regressions.

* add missing name

Author: jcscottiii

infra/storage/spanner/migrations/000001.sql

@@ -70,7 +70,7 @@ CREATE TABLE IF NOT EXISTS WPTRunFeatureMetrics (
     BrowserName STRING(64) NOT NULL,
     TimeStart TIMESTAMP NOT NULL,
     -- End denormalized data.
-    FOREIGN KEY (WebFeatureID) REFERENCES WebFeatures(ID),
+    CONSTRAINT FK_WPTRunFeatureMetricsWebFeatureID FOREIGN KEY (WebFeatureID) REFERENCES WebFeatures(ID) ON DELETE CASCADE,
     FOREIGN KEY (ID) REFERENCES WPTRuns(ID)
 ) PRIMARY KEY (ID, WebFeatureID)
 ,    INTERLEAVE IN PARENT WPTRuns ON DELETE CASCADE;
@@ -101,7 +101,7 @@ CREATE TABLE IF NOT EXISTS BrowserFeatureAvailabilities (
     BrowserName STRING(64) NOT NULL, -- From BCD not wpt.fyi.
     BrowserVersion STRING(8) NOT NULL, -- From BCD not wpt.fyi. Only contains major number.
     WebFeatureID STRING(36) NOT NULL, -- From web features table.
-    FOREIGN KEY (WebFeatureID) REFERENCES WebFeatures(ID),
+    CONSTRAINT FK_BrowserFeatureAvailabilitiesWebFeatureID FOREIGN KEY (WebFeatureID) REFERENCES WebFeatures(ID) ON DELETE CASCADE,
     FOREIGN KEY (BrowserName, BrowserVersion) REFERENCES BrowserReleases(BrowserName, BrowserVersion),
 ) PRIMARY KEY (WebFeatureID, BrowserName);
 
@@ -115,7 +115,7 @@ CREATE TABLE IF NOT EXISTS FeatureBaselineStatus (
     Status STRING(16),
     LowDate TIMESTAMP,
     HighDate TIMESTAMP,
-    FOREIGN KEY (WebFeatureID) REFERENCES WebFeatures(ID),
+    CONSTRAINT FK_FeatureBaselineStatusWebFeatureID FOREIGN KEY (WebFeatureID) REFERENCES WebFeatures(ID) ON DELETE CASCADE,
     -- Options come from https://github.com/web-platform-dx/web-features/blob/3d4d066c47c9f07514bf743b3955572a6073ff1e/packages/web-features/README.md?plain=1#L17-L24
     CHECK (Status IN ('none', 'low', 'high'))
 ) PRIMARY KEY (WebFeatureID);

infra/storage/spanner/migrations/000003.sql

@@ -16,5 +16,5 @@
 CREATE TABLE IF NOT EXISTS FeatureSpecs (
     WebFeatureID STRING(36) NOT NULL,
     Links ARRAY<STRING(128)>,
-    FOREIGN KEY (WebFeatureID) REFERENCES WebFeatures(ID),
+    CONSTRAINT FK_FeatureSpecsWebFeatureID FOREIGN KEY (WebFeatureID) REFERENCES WebFeatures(ID) ON DELETE CASCADE,
 ) PRIMARY KEY (WebFeatureID);

infra/storage/spanner/migrations/000011.sql

@@ -17,7 +17,7 @@ CREATE TABLE IF NOT EXISTS LatestDailyChromiumHistogramMetrics (
     WebFeatureID STRING(36) NOT NULL,
     ChromiumHistogramEnumValueID STRING(36) NOT NULL,
     Day DATE NOT NULL,
-    FOREIGN KEY (WebFeatureID) REFERENCES WebFeatures(ID),
+    CONSTRAINT FK_LatestDailyChromiumHistogramMetricsWebFeatureID FOREIGN KEY (WebFeatureID) REFERENCES WebFeatures(ID) ON DELETE CASCADE,
     FOREIGN KEY (ChromiumHistogramEnumValueID) REFERENCES ChromiumHistogramEnumValues(ID) ON DELETE CASCADE,
     FOREIGN KEY (ChromiumHistogramEnumValueID, Day) REFERENCES DailyChromiumHistogramMetrics(ChromiumHistogramEnumValueID, Day) ON DELETE CASCADE,
 ) PRIMARY KEY (WebFeatureID, ChromiumHistogramEnumValueID);