Skip to content

Commit 72a2d3b

Browse files
committed
rename
1 parent c344a7d commit 72a2d3b

File tree

2 files changed

+20
-20
lines changed

2 files changed

+20
-20
lines changed

lib/gcpspanner/baseline_status_count.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ type fbsColumn string
6767

6868
const fbsColumnLowDate fbsColumn = "fbs.LowDate"
6969

70-
// ListBaselineStatusCount retrieves a cumulative count of baseline features over time.
71-
func (c *Client) ListBaselineStatusCount(
70+
// ListBaselineStatusCounts retrieves a cumulative count of baseline features over time.
71+
func (c *Client) ListBaselineStatusCounts(
7272
ctx context.Context,
7373
dateType BaselineDateType,
7474
startAt time.Time,
@@ -110,7 +110,7 @@ func (c *Client) ListBaselineStatusCount(
110110
}
111111

112112
// 4. Process results and update cumulative count
113-
stmt := createListBaselineStatusCountStatement(dateType, startAt, endAt, pageSize, parsedToken, excludedFeatureIDs)
113+
stmt := createListBaselineStatusCountsStatement(dateType, startAt, endAt, pageSize, parsedToken, excludedFeatureIDs)
114114

115115
iter := txn.Query(ctx, stmt)
116116
defer iter.Stop()
@@ -199,8 +199,8 @@ func (c *Client) getInitialBaselineStatusCount(
199199
return initialCount, err
200200
}
201201

202-
// createListBaselineStatusCountStatement creates the Spanner statement for the main query.
203-
func createListBaselineStatusCountStatement(
202+
// createListBaselineStatusCountsStatement creates the Spanner statement for the main query.
203+
func createListBaselineStatusCountsStatement(
204204
dateType BaselineDateType,
205205
startAt time.Time,
206206
endAt time.Time,

lib/gcpspanner/baseline_status_count_test.go

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ import (
2121
"time"
2222
)
2323

24-
func TestListBaselineStatusCount_LowDate(t *testing.T) {
24+
func TestListBaselineStatusCounts_LowDate(t *testing.T) {
2525
restartDatabaseContainer(t)
2626
ctx := context.Background()
27-
loadDataForListBaselineStatusCount(ctx, t)
27+
loadDataForListBaselineStatusCounts(ctx, t)
2828

2929
startAt := time.Date(2024, 1, 1, 0, 0, 0, 0, time.UTC)
3030
endAt := time.Date(2025, 1, 1, 0, 0, 0, 0, time.UTC)
@@ -40,29 +40,29 @@ func TestListBaselineStatusCount_LowDate(t *testing.T) {
4040
NextPageToken: nil,
4141
}
4242

43-
result, err := spannerClient.ListBaselineStatusCount(ctx, BaselineDateTypeLow, startAt, endAt, pageSize, nil)
43+
result, err := spannerClient.ListBaselineStatusCounts(ctx, BaselineDateTypeLow, startAt, endAt, pageSize, nil)
4444
if err != nil {
45-
t.Fatalf("ListBaselineStatusCount failed: %v", err)
45+
t.Fatalf("ListBaselineStatusCounts failed: %v", err)
4646
}
4747

4848
if !reflect.DeepEqual(result, expected) {
4949
t.Errorf("Unexpected result. Got: %+v, Want: %+v", result, expected)
5050
}
5151
}
5252

53-
func TestListBaselineStatusCount_Pagination(t *testing.T) {
53+
func TestListBaselineStatusCounts_Pagination(t *testing.T) {
5454
restartDatabaseContainer(t)
5555
ctx := context.Background()
56-
loadDataForListBaselineStatusCount(ctx, t)
56+
loadDataForListBaselineStatusCounts(ctx, t)
5757

5858
startAt := time.Date(2024, 1, 1, 0, 0, 0, 0, time.UTC)
5959
endAt := time.Date(2025, 1, 1, 0, 0, 0, 0, time.UTC)
6060
pageSize := 3
6161

6262
// First page
63-
result1, err := spannerClient.ListBaselineStatusCount(ctx, BaselineDateTypeLow, startAt, endAt, pageSize, nil)
63+
result1, err := spannerClient.ListBaselineStatusCounts(ctx, BaselineDateTypeLow, startAt, endAt, pageSize, nil)
6464
if err != nil {
65-
t.Fatalf("ListBaselineStatusCount failed: %v", err)
65+
t.Fatalf("ListBaselineStatusCounts failed: %v", err)
6666
}
6767

6868
expected1 := &BaselineStatusCountResultPage{
@@ -79,10 +79,10 @@ func TestListBaselineStatusCount_Pagination(t *testing.T) {
7979
}
8080

8181
// Second page
82-
result2, err := spannerClient.ListBaselineStatusCount(
82+
result2, err := spannerClient.ListBaselineStatusCounts(
8383
ctx, BaselineDateTypeLow, startAt, endAt, pageSize, result1.NextPageToken)
8484
if err != nil {
85-
t.Fatalf("ListBaselineStatusCount failed: %v", err)
85+
t.Fatalf("ListBaselineStatusCounts failed: %v", err)
8686
}
8787

8888
expected2 := &BaselineStatusCountResultPage{
@@ -97,10 +97,10 @@ func TestListBaselineStatusCount_Pagination(t *testing.T) {
9797
}
9898
}
9999

100-
func TestListBaselineStatusCount_ExcludedFeatures(t *testing.T) {
100+
func TestListBaselineStatusCounts_ExcludedFeatures(t *testing.T) {
101101
restartDatabaseContainer(t)
102102
ctx := context.Background()
103-
loadDataForListBaselineStatusCount(ctx, t)
103+
loadDataForListBaselineStatusCounts(ctx, t)
104104

105105
// Exclude "FeatureB" and "FeatureE"
106106
excludedFeatures := []string{"FeatureB", "FeatureE"}
@@ -124,17 +124,17 @@ func TestListBaselineStatusCount_ExcludedFeatures(t *testing.T) {
124124
NextPageToken: nil,
125125
}
126126

127-
result, err := spannerClient.ListBaselineStatusCount(ctx, BaselineDateTypeLow, startAt, endAt, pageSize, nil)
127+
result, err := spannerClient.ListBaselineStatusCounts(ctx, BaselineDateTypeLow, startAt, endAt, pageSize, nil)
128128
if err != nil {
129-
t.Fatalf("ListBaselineStatusCount failed: %v", err)
129+
t.Fatalf("ListBaselineStatusCounts failed: %v", err)
130130
}
131131

132132
if !reflect.DeepEqual(result, expected) {
133133
t.Errorf("Unexpected result. Got: %+v, Want: %+v", result, expected)
134134
}
135135
}
136136

137-
func loadDataForListBaselineStatusCount(ctx context.Context, t *testing.T) {
137+
func loadDataForListBaselineStatusCounts(ctx context.Context, t *testing.T) {
138138
// Insert web features
139139
webFeatures := []WebFeature{
140140
{FeatureKey: "FeatureA", Name: "Feature A"},

0 commit comments

Comments
 (0)