Skip to content

Commit 9cc0a75

Browse files
committed
Revert: Show BCD mapping progress on front page #819
This removes the ability to see the bcd mapping progress on the front page.
1 parent 4526fbc commit 9cc0a75

36 files changed

+6
-511
lines changed

.dev/gcs/Dockerfile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,5 @@
1414

1515
FROM fsouza/fake-gcs-server:1.52.2
1616

17-
# Preload a webfeatures bucket
18-
COPY data/webfeatures /data/webfeatures
19-
2017
# https://cloud.google.com/datastore/docs/tools/datastore-emulator
2118
CMD ["-scheme", "http", "-public-host", "gcs:4443", "-external-url", "http://gcs:4443"]

.dev/gcs/data/webfeatures/progress.json

Lines changed: 0 additions & 3 deletions
This file was deleted.

DEPLOYMENT.md

Lines changed: 0 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -140,25 +140,6 @@ terraform apply \
140140
-var "env_id=${ENV_ID}"
141141
```
142142
143-
### Update the value of the BCD progress
144-
145-
Go to https://github.com/web-platform-dx/web-features/releases and there should be a line like `X% coverage of mdn/browser-compat-data features`. Copy the percentage.
146-
147-
```sh
148-
BCD_VALUE=62 # Replace the value
149-
echo "{\"bcd_map_progress\": $BCD_VALUE}" | gsutil -h "Content-Type:application/json" cp - gs://web-features-progress-staging/progress.json
150-
```
151-
152-
### Or, disable the BCD progress text
153-
154-
**Note:** Normally, we should only need to update the progress. **ONLY** do
155-
this section if there is a request to disable the text. Otherwise, you can skip
156-
this part and consider the deployment done.
157-
158-
```sh
159-
echo "{\"is_disabled\": true}" | gsutil -h "Content-Type:application/json" cp - gs://web-features-progress-staging/progress.json
160-
```
161-
162143
## Deploy Prod
163144
164145
```sh
@@ -192,22 +173,3 @@ terraform apply \
192173
-var-file=".envs/prod.tfvars" \
193174
-var "env_id=${ENV_ID}"
194175
```
195-
196-
### Update the value of the BCD progress
197-
198-
Go to https://github.com/web-platform-dx/web-features/releases and there should be a line like `X% coverage of mdn/browser-compat-data features`. Copy the percentage.
199-
200-
```sh
201-
BCD_VALUE=62 # Replace the value
202-
echo "{\"bcd_map_progress\": $BCD_VALUE}" | gsutil -h "Content-Type:application/json" cp - gs://web-features-progress-prod/progress.json
203-
```
204-
205-
### Or, disable the BCD progress text
206-
207-
**Note:** Normally, we should only need to update the progress. **ONLY** do
208-
this section if there is a request to disable the text. Otherwise, you can skip
209-
this part and consider the deployment done.
210-
211-
```sh
212-
echo "{\"is_disabled\": true}" | gsutil -h "Content-Type:application/json" cp - gs://web-features-progress-prod/progress.json
213-
```

Makefile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,26 +66,22 @@ port-forward-manual: port-forward-terminate
6666
kubectl wait --for=condition=ready pod/frontend
6767
kubectl wait --for=condition=ready pod/backend
6868
kubectl wait --for=condition=ready pod/auth
69-
kubectl wait --for=condition=ready pod/gcs
7069
kubectl port-forward --address 127.0.0.1 pod/frontend 5555:5555 2>&1 >/dev/null &
7170
kubectl port-forward --address 127.0.0.1 pod/backend 8080:8080 2>&1 >/dev/null &
7271
kubectl port-forward --address 127.0.0.1 pod/auth 9099:9099 2>&1 >/dev/null &
7372
kubectl port-forward --address 127.0.0.1 pod/auth 9100:9100 2>&1 >/dev/null &
74-
kubectl port-forward --address 127.0.0.1 pod/gcs 4443:4443 2>&1 >/dev/null &
7573
curl -s -o /dev/null -m 5 http://localhost:8080 || true
7674
curl -s -o /dev/null -m 5 http://localhost:5555 || true
7775
curl -s -o /dev/null -m 5 http://localhost:8092 || true
7876
curl -s -o /dev/null -m 5 http://localhost:9099 || true
7977
curl -s -o /dev/null -m 5 http://localhost:9100 || true
80-
curl -s -o /dev/null -m 5 http://localhost:4443 || true
8178

8279
port-forward-terminate:
8380
fuser -k 5555/tcp || true
8481
fuser -k 8080/tcp || true
8582
fuser -k 8092/tcp || true
8683
fuser -k 9099/tcp || true
8784
fuser -k 9100/tcp || true
88-
fuser -k 4443/tcp || true
8985

9086
# Prerequisite target to start minikube if necessary
9187
minikube-running:

e2e/tests/overview-page.spec.ts

Lines changed: 0 additions & 59 deletions
Original file line numberDiff line numberDiff line change
@@ -272,62 +272,3 @@ test('Typing slash focuses on searchbox', async ({page}) => {
272272
// Later characters, including slashes, go in the searchbox.
273273
await expect(searchbox).toHaveAttribute('value', 'def/ghi');
274274
});
275-
276-
test.describe('web features mapping progress', () => {
277-
const mappingPattern = /Percentage of features mapped:\s+\d+(\.\d+)?%/;
278-
test('Overview page has the progress with a clickable link', async ({
279-
page,
280-
}) => {
281-
await gotoOverviewPageUrl(page, 'http://localhost:5555/');
282-
283-
const textLocator = page.getByText(mappingPattern);
284-
await expect(textLocator).toBeVisible();
285-
286-
const linkLocator = textLocator.locator('a');
287-
288-
// Assert the link's text content matches the number pattern
289-
const linkText = await linkLocator.textContent();
290-
expect(linkText).toMatch(/\d+(\.\d+)?%/);
291-
292-
await linkLocator.click();
293-
await expect(page).toHaveURL(
294-
'https://github.com/web-platform-dx/web-features',
295-
);
296-
});
297-
298-
test('Web Features progress request fails and shows toast', async ({
299-
page,
300-
}) => {
301-
// Mock the API to return an error when requesting mapping feature progress.
302-
page.on('request', async request => {
303-
await page.route('**/progress.json*', async route => {
304-
return route.abort();
305-
});
306-
});
307-
await gotoOverviewPageUrl(page, 'http://localhost:5555/');
308-
309-
// Assert toast is visible
310-
// For some reason it brings up two toasts. We should fix that.
311-
const toast = page.locator('.toast').first();
312-
await toast.waitFor({state: 'visible'});
313-
});
314-
315-
test('Web Features progress can be removed if is_disabled=true', async ({
316-
page,
317-
}) => {
318-
// Mock the API to is_disabled flag.
319-
page.on('request', async request => {
320-
await page.route('**/progress.json*', route =>
321-
route.fulfill({
322-
status: 200,
323-
body: '{"is_disabled": true}',
324-
}),
325-
);
326-
});
327-
await gotoOverviewPageUrl(page, 'http://localhost:5555/');
328-
329-
// Assert mapping text is not visible
330-
const textLocator = page.getByText(mappingPattern);
331-
await expect(textLocator).toBeVisible({visible: false});
332-
});
333-
});
-4.79 KB
Loading
-5.16 KB
Loading
-4.89 KB
Loading
-4.38 KB
Loading
-4.46 KB
Loading

0 commit comments

Comments
 (0)