Move e2e 404 test utility functions to specific file

Author: suprith-hub

e2e/tests/404.spec.ts

@@ -15,8 +15,7 @@
  */
 
 import {test, expect} from '@playwright/test';
-
-const BASE_URL = 'http://localhost:5555';
+import { BASE_URL, expect404PageButtons, goTo404Page } from './utils';
 
 test('Bad URL redirection to 404 page', async ({page}) => {
   const badUrls = [
@@ -52,35 +51,14 @@ test('Bad URL redirection to 404 page', async ({page}) => {
   }
 });
 
-async function goTo404Page(page, query: string): Promise<void> {
-  await page.goto(`${BASE_URL}/features/${query}`);
-  await expect(page).toHaveURL(
-    `${BASE_URL}/errors-404/feature-not-found?q=${query}`,
-  );
-
-  const response = await page.context().request.fetch(page.url());
-  expect(response.status()).toBe(404);
-}
-
-async function expectButtons(page, {hasSearch}: {hasSearch: boolean}) {
-  await expect(page.locator('#error-action-home-btn')).toBeVisible();
-  await expect(page.locator('#error-action-report')).toBeVisible();
-
-  if (hasSearch) {
-    await expect(page.locator('#error-action-search-btn')).toBeVisible();
-  } else {
-    await expect(page.locator('#error-action-search-btn')).toHaveCount(0);
-  }
-}
-
 test('shows similar features and all buttons when results exist', async ({
   page,
 }) => {
   const query = 'g';
   await goTo404Page(page, query);
 
   await expect(page.locator('.similar-features-container')).toBeVisible();
-  await expectButtons(page, {hasSearch: true});
+  await expect404PageButtons(page, {hasSearch: true});
 
   const similarContainerButton = page.locator('#error-action-search-btn');
   const pageContainer = page.locator('.page-container');
@@ -102,7 +80,7 @@ test('shows only home and report buttons when no similar features found', async
   await goTo404Page(page, query);
 
   await expect(page.locator('.similar-features-container')).toHaveCount(0);
-  await expectButtons(page, {hasSearch: false});
+  await expect404PageButtons(page, {hasSearch: false});
 
   await expect(page.locator('#error-detailed-message')).toContainText(
     `We could not find Feature ID: ${query}`,

e2e/tests/utils.ts

@@ -18,6 +18,8 @@ import {Page, expect} from '@playwright/test';
 
 const DEFAULT_FAKE_NOW = 'Dec 1 2020 12:34:56';
 
+export const BASE_URL = 'http://localhost:5555';
+
 export async function setupFakeNow(
   page: Page,
   fakeNowDateString = DEFAULT_FAKE_NOW,
@@ -73,3 +75,24 @@ export async function getOverviewPageFeatureCount(page: Page): Promise<number> {
   const text = await statsSummary.innerText();
   return parseInt(text.match(regex)![1]);
 }
+
+export async function goTo404Page(page, query: string): Promise<void> {
+  await page.goto(`${BASE_URL}/features/${query}`);
+  await expect(page).toHaveURL(
+    `${BASE_URL}/errors-404/feature-not-found?q=${query}`,
+  );
+
+  const response = await page.context().request.fetch(page.url());
+  expect(response.status()).toBe(404);
+}
+
+export async function expect404PageButtons(page, {hasSearch}: {hasSearch: boolean}) {
+  await expect(page.locator('#error-action-home-btn')).toBeVisible();
+  await expect(page.locator('#error-action-report')).toBeVisible();
+
+  if (hasSearch) {
+    await expect(page.locator('#error-action-search-btn')).toBeVisible();
+  } else {
+    await expect(page.locator('#error-action-search-btn')).toHaveCount(0);
+  }
+}