@@ -473,7 +534,7 @@ export class FeaturePage extends BaseChartsPage {
const status = this.feature?.baseline?.status;
if (status === undefined) return html``;
- const chipConfig = BASELINE_CHIP_CONFIGS[status];
+ const chipConfig = getBaselineChipConfig(status, this.feature.discouraged);
const sinceDate = this.feature?.baseline?.low_date;
return html`
@@ -581,6 +642,7 @@ export class FeaturePage extends BaseChartsPage {
return html`
+ ${this.renderDiscouragedNotice(this.feature?.discouraged)}
${this.renderCrumbs()}
diff --git a/frontend/src/static/js/components/webstatus-overview-cells.ts b/frontend/src/static/js/components/webstatus-overview-cells.ts
index b0fc33e7a..9b80989f7 100644
--- a/frontend/src/static/js/components/webstatus-overview-cells.ts
+++ b/frontend/src/static/js/components/webstatus-overview-cells.ts
@@ -171,10 +171,31 @@ interface BaselineChipConfig {
word: string;
}
-export const BASELINE_CHIP_CONFIGS: Record<
- NonNullable
,
+export function getBaselineChipConfig(
+ status: NonNullable,
+ discouraged?: components['schemas']['FeatureDiscouragedInfo'],
+): BaselineChipConfig {
+ if (discouraged) {
+ // For now, just use the generic discouraged type
+ return BASELINE_CHIP_CONFIGS['discouraged'];
+ }
+
+ return BASELINE_CHIP_CONFIGS[status];
+}
+
+// In the future, there will be types like Obsolete and Pending Removal.
+// For now, there is only a generic 'discouraged' type.
+type DiscouragedType = 'discouraged';
+
+const BASELINE_CHIP_CONFIGS: Record<
+ | NonNullable
+ | DiscouragedType,
BaselineChipConfig
> = {
+ discouraged: {
+ icon: 'discouraged.svg',
+ word: 'Discouraged',
+ },
limited: {
icon: 'cross.svg',
word: 'Limited availability',
@@ -292,7 +313,7 @@ export const renderBaselineStatus: CellRenderer = (
) => {
const baselineStatus = feature.baseline?.status;
if (baselineStatus === undefined) return html``;
- const chipConfig = BASELINE_CHIP_CONFIGS[baselineStatus];
+ const chipConfig = getBaselineChipConfig(baselineStatus, feature.discouraged);
const columnOptions: ColumnOptionKey[] = parseColumnOptions(
getColumnOptions(routerLocation),
);
diff --git a/util/cmd/load_fake_data/main.go b/util/cmd/load_fake_data/main.go
index 879055b88..acdf56d86 100644
--- a/util/cmd/load_fake_data/main.go
+++ b/util/cmd/load_fake_data/main.go
@@ -50,6 +50,8 @@ const numberOfFeatures = 80
// Feature Key used for feature page tests.
const featurePageFeatureKey = "anchor-positioning"
+const discouragedFeatureKey = "discouraged"
+
// Allows us to regenerate the same values between runs.
const seedValue = 1024
@@ -97,7 +99,7 @@ func getSpecialFeatureDetails() []struct {
{
// Used for feature detail page tests.
name: "Anchor Positioning",
- id: "anchor-positioning",
+ id: featurePageFeatureKey,
},
{
name: "Cross-Document View Transitions",
@@ -142,6 +144,10 @@ func getSpecialFeatureDetails() []struct {
name: "Before Split Feature",
id: "before-split-feature",
},
+ {
+ name: "Discouraged Feature",
+ id: discouragedFeatureKey,
+ },
}
}
@@ -843,6 +849,13 @@ func generateData(ctx context.Context, spannerClient *gcpspanner.Client, datasto
slog.InfoContext(ctx, "feature developer signals generated",
"amount of signals generated", signalsGenerated)
+ discouragedFeaturesCount, err := generateDiscouragedFeatures(ctx, spannerClient, features)
+ if err != nil {
+ return fmt.Errorf("discouraged features generation failed %w", err)
+ }
+ slog.InfoContext(ctx, "discouraged features generated",
+ "amount of discouraged features generated", discouragedFeaturesCount)
+
err = generateEvolutionOfFeatures(ctx, spannerClient, fh)
if err != nil {
return fmt.Errorf("feature evolution generation failed %w", err)
@@ -1118,6 +1131,36 @@ func generateFeatureDeveloperSignals(
return len(signals), nil
}
+func generateDiscouragedFeatures(
+ ctx context.Context, client *gcpspanner.Client, features []gcpspanner.SpannerWebFeature) (int, error) {
+ discouragedFeatures := 0
+ for _, feature := range features {
+
+ // Only 10 percent of the features are discouraged. Or if it is the discouragedFeatureKey.
+ // Also, ensure that it is not the feature page feature key.
+ var modifier = r.Intn(10)
+ if (modifier == 0 || feature.FeatureKey == discouragedFeatureKey) &&
+ feature.FeatureKey != featurePageFeatureKey {
+ err := client.UpsertFeatureDiscouragedDetails(ctx, feature.FeatureKey,
+ gcpspanner.FeatureDiscouragedDetails{
+ AccordingTo: []string{
+ "https://webstatus.dev",
+ "https://example.com",
+ },
+ Alternatives: []string{
+ featurePageFeatureKey,
+ },
+ })
+ if err != nil {
+ return 0, err
+ }
+ discouragedFeatures++
+ }
+ }
+
+ return discouragedFeatures, nil
+}
+
func initFirebaseAuthClient(ctx context.Context, projectID string) *auth.Client {
// nolint:exhaustruct // WONTFIX - will rely on the defaults on this third party struct.
firebaseApp, err := firebase.NewApp(context.Background(), &firebase.Config{
+