feat(frontend): add notification channels page #2152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcscottiii
added a commit
that referenced
this pull request
Jan 2, 2026
I had the gemini CLI examine some of its shortcomings while working on #2152 It updated GEMINI.md with its learnings
jcscottiii
force-pushed
the
jcscottiii/email-worker-pt10
branch
from
b4750c5 to
5451199
Compare
jcscottiii
force-pushed
the
jcscottiii/ui-notifications
branch
from
97c9792 to
62b7e7d
Compare
jcscottiii
added a commit
that referenced
this pull request
Jan 14, 2026
I had the gemini CLI examine some of its shortcomings while working on #2152 It updated GEMINI.md with its learnings
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 14, 2026
I had the gemini CLI examine some of its shortcomings while working on #2152 It updated GEMINI.md with its learnings
jcscottiii
force-pushed
the
jcscottiii/email-worker-pt10
branch
from
5451199 to
24ed8ce
Compare
jcscottiii
force-pushed
the
jcscottiii/ui-notifications
branch
from
62b7e7d to
fb98768
Compare
jrobbins
approved these changes
Jan 15, 2026
jcscottiii
force-pushed
the
jcscottiii/email-worker-pt10
branch
from
24ed8ce to
507eff2
Compare
Implements the new "Notification Channels" page, providing users with a centralized location to manage how they receive updates. This feature is a foundational step towards enabling subscriptions and personalized notifications. Key changes include: - **New Page Component:** Adds a new page at `/settings/notification-channels`, accessible only to authenticated users. - **Component Architecture:** The page is composed of a main container and three distinct panel components for each notification type (Email, RSS, Webhook), following a composition-over-inheritance pattern. - **Base Panel Component:** A new reusable `<webstatus-notification-panel>` was created to ensure a consistent look and feel across all panels and to handle loading states gracefully with skeleton placeholders. - **Email Channel Display:** The page now fetches and displays the user's email notification channels, which are synced from their verified GitHub emails via the existing `pingUser` flow. A tooltip has been added to inform users of this behavior. - **Coming Soon Placeholders:** The RSS and Webhook panels are included as placeholders with "Coming soon" messages and disabled "Create" buttons, preparing the UI for future implementation. - **Sidebar Refactoring:** The main sidebar has been refactored to use a `renderNavItem` helper function for top-level links, improving code consistency. The "Notification Channels" link now appears as a top-level item under a "Settings" section that is only visible to logged-in users. - **Testing:** Comprehensive unit tests for the new page and all panel components have been added. A new end-to-end (Playwright) test ensures the page functions correctly for both authenticated and unauthenticated users, and includes visual regression snapshots.
jcscottiii
force-pushed
the
jcscottiii/ui-notifications
branch
from
fb98768 to
840db6c
Compare
The current sorting of the channels goes by updatedAt and ID. Upon the first commit where we create all of them in the same transaction, they all have the same updated at. And the second thing is by the ID which is a UUID. This can still lead to unstable results for the playwright tests. Now, we sort them. Also, use a constant enum for the channel type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the new "Notification Channels" page, providing users with a centralized location to manage how they receive updates. This feature is a foundational step towards enabling subscriptions and personalized notifications.
Key changes include:
/settings/notification-channels, accessible only to authenticated users.<webstatus-notification-panel>was created to ensure a consistent look and feel across all panels and to handle loading states gracefully with skeleton placeholders.pingUserflow. A tooltip has been added to inform users of this behavior.renderNavItemhelper function for top-level links, improving code consistency. The "Notification Channels" link now appears as a top-level item under a "Settings" section that is only visible to logged-in users.