webpack plugin updates for v5 (#2087)

* Initial GenerateSW changes.

* WIP.

* Basic InjectManifest functionality.

* Normalize webpack option validation.

* Working-ish?

* Copy over some compiler options.

* More mode magic

* Manifest transformations should work

* Normalized error reporting a bit.

* Switch to Proxx's loadz0r config

* Tweak the default exclude

* Play nicely with SplitChunkPlugin

* Add a warning about missing chunks.

* Rename a test.

* Updated a few comments.

* Test-related updates

* Further test fixes.

* Pretty complete GenerateSW test suite.

* InjectManifest tests.

* Linting.

* Copyright dates.

* Update jsdoc-baseline

* lockfile update

* Fix the generate-sw test on Windows.

* Switch to upath

* Fix a proxied call to upath

* Missed a @Private

* A few nits.

Author: jeffposnick

.eslintrc.js

@@ -90,9 +90,10 @@ module.exports = {
     },
   }, {
     files: [
-      'test/workbox-build/static/**/*.js',
+      'test/*/static/**/*.js',
     ],
     rules: {
+      'no-console': 0,
       'no-unused-vars': 0,
       'no-undef': 0,
     },

infra/testing/confirm-directory-contains.js

@@ -0,0 +1,18 @@
+/*
+  Copyright 2019 Google LLC
+
+  Use of this source code is governed by an MIT-style
+  license that can be found in the LICENSE file or at
+  https://opensource.org/licenses/MIT.
+*/
+
+const expect = require('chai').expect;
+const globby = require('globby');
+const path = require('path');
+
+module.exports = async (directory, expectedContents) => {
+  const globbedFiles = await globby(directory);
+  const filesWithNativeSeparator =
+      globbedFiles.map((file) => file.replace(/\//g, path.sep));
+  expect(filesWithNativeSeparator).to.have.members(expectedContents);
+};

infra/testing/webpack-build-check.js

@@ -0,0 +1,24 @@
+/*
+  Copyright 2019 Google LLC
+
+  Use of this source code is governed by an MIT-style
+  license that can be found in the LICENSE file or at
+  https://opensource.org/licenses/MIT.
+*/
+
+
+module.exports = (webpackError, stats) => {
+  if (webpackError) {
+    throw new Error(webpackError.message);
+  }
+
+  const statsJson = stats.toJson('verbose');
+
+  if (statsJson.errors.length > 0) {
+    throw new Error(statsJson.errors.join('\n'));
+  }
+
+  if (statsJson.warnings.length > 0) {
+    throw new Error(statsJson.warnings.join('\n'));
+  }
+};

package-lock.json

@@ -80,7 +80,7 @@
     "gzip-size": "^5.0.0",
     "html-webpack-plugin": "^3.2.0",
     "jsdoc": "^3.5.5",
-    "jsdoc-baseline": "https://github.com/hegemonic/baseline/tarball/master",
+    "jsdoc-baseline": "git://github.com/hegemonic/baseline.git#c492ee17",
     "lerna": "^3.4.0",
     "minimist": "^1.2.0",
     "mocha": "^5.2.0",

package.json

@@ -28,7 +28,7 @@
     "fs-extra": "^4.0.2",
     "glob": "^7.1.3",
     "lodash.template": "^4.4.0",
-    "pretty-bytes": "^5.1.0",
+    "pretty-bytes": "^5.2.0",
     "rollup": "^1.12.3",
     "rollup-plugin-babel": "^4.3.2",
     "rollup-plugin-loadz0r": "^0.7.1",
@@ -38,6 +38,7 @@
     "stringify-object": "^3.3.0",
     "strip-comments": "^1.0.2",
     "tempy": "^0.3.0",
+    "upath": "^1.1.2",
     "workbox-background-sync": "^4.3.1",
     "workbox-broadcast-update": "^4.3.1",
     "workbox-cacheable-response": "^4.3.1",