Move URLs to gradle config

Author: orbital17

packages/core/src/lib/features/EmptyFeature.ts

@@ -21,9 +21,11 @@ export class EmptyFeature implements Feature {
   buildGradle: {
     repositories: string[];
     dependencies: string[];
+    configs: string[];
   } = {
     repositories: new Array<string>(),
     dependencies: new Array<string>(),
+    configs: new Array<string>(),
   };
 
   androidManifest: {

packages/core/src/lib/features/Feature.ts

@@ -41,6 +41,10 @@ export interface Feature {
      *    Example `androidx.appcompat:appcompat:1.2.0`.
      */
     dependencies: string[];
+    /**
+     * Entries to be added the `android.defaultConfig` section.
+     */
+    configs: string[];
   };
 
   /**

packages/core/src/lib/features/FeatureManager.ts

@@ -38,6 +38,7 @@ export class FeatureManager {
   buildGradle = {
     repositories: new Set<string>(),
     dependencies: new Set<string>(),
+    configs: new Set<string>(),
   };
   androidManifest = {
     permissions: new Set<string>(),
@@ -125,6 +126,10 @@ export class FeatureManager {
       this.buildGradle.dependencies.add(dep);
     });
 
+    feature.buildGradle.configs.forEach((dep) => {
+      this.buildGradle.configs.add(dep);
+    });
+
     // Adds properties to application.
     feature.applicationClass.imports.forEach((imp) => {
       this.applicationClass.imports.add(imp);

packages/core/src/lib/features/FileHandlingFeature.ts

@@ -23,7 +23,7 @@ const activityAliasTemplate = (handler: FileHandler, index: number): string => `
         android:targetActivity="LauncherActivity"
         android:exported="true">
         <meta-data android:name="android.support.customtabs.trusted.FILE_HANDLING_ACTION_URL"
-            android:value="${handler.actionUrl}" /> 
+            android:value="@string/fileHandlingActionUrl${index}" /> 
         <intent-filter>
             <action android:name="android.intent.action.VIEW"/>
             <category android:name="android.intent.category.DEFAULT" />
@@ -42,6 +42,8 @@ export class FileHandlingFeature extends EmptyFeature {
     if (fileHandlers.length === 0) return;
     for (let i = 0; i < fileHandlers.length; i++) {
       this.androidManifest.components.push(activityAliasTemplate(fileHandlers[i], i));
+      this.buildGradle.configs.push(
+          `resValue "string", "fileHandlingActionUrl${i}", "${fileHandlers[i].actionUrl}"`);
     }
   }
 }

packages/core/template_project/app/build.gradle

@@ -148,6 +148,10 @@ android {
 
         resValue "bool", "enableSiteSettingsShortcut", twaManifest.enableSiteSettingsShortcut
         resValue "string", "orientation", twaManifest.orientation
+
+        <% for(const config of buildGradle.configs) { %>
+        <%= config %>
+        <% } %>
     }
     buildTypes {
         release {