Added support for minimal-ui and browser display modes

Author: gstepniewski-google

packages/core/src/lib/TwaManifest.ts

@@ -41,7 +41,8 @@ const SHORT_NAME_MAX_SIZE = 12;
 const MIN_NOTIFICATION_ICON_SIZE = 48;
 
 // Supported display modes for TWA
-const DISPLAY_MODE_VALUES = ['standalone', 'minimal-ui', 'fullscreen', 'fullscreen-sticky'];
+const DISPLAY_MODE_VALUES = ['standalone', 'minimal-ui', 'fullscreen', 'fullscreen-sticky',
+  'browser'];
 export type DisplayMode = typeof DISPLAY_MODE_VALUES[number];
 export const DisplayModes: DisplayMode[] = [...DISPLAY_MODE_VALUES];
 

packages/core/src/spec/lib/TwaManifestSpec.ts

@@ -196,12 +196,6 @@ describe('TwaManifest', () => {
       expect(twaManifest.maskableIconUrl).toBe('https://pwa-directory.com/favicons/maskable.png');
       expect(twaManifest.monochromeIconUrl).toBe('https://pwa-directory.com/favicons/monochrome.png');
     });
-
-    it('Replaces unsupported display modes with `standalone`', () => {
-      const manifestUrl = new URL('https://pwa-directory.com/manifest.json');
-      expect(TwaManifest.fromWebManifestJson(manifestUrl, {display: 'browser'}).display)
-          .toBe('standalone');
-    });
   });
 
   describe('#constructor', () => {
@@ -345,10 +339,10 @@ describe('TwaManifest', () => {
       expect(asDisplayMode('standalone')).toBe('standalone');
       expect(asDisplayMode('fullscreen')).toBe('fullscreen');
       expect(asDisplayMode('minimal-ui')).toBe('minimal-ui');
+      expect(asDisplayMode('browser')).toBe('browser');
     });
 
     it('Returns null for unsupported display modes', () => {
-      expect(asDisplayMode('browser')).toBeNull();
       expect(asDisplayMode('bogus')).toBeNull();
       expect(asDisplayMode('')).toBeNull();
     });

packages/core/template_project/app/src/main/AndroidManifest.xml

@@ -164,6 +164,12 @@
             <% } else if (display === 'fullscreen-sticky') { %>
             <meta-data android:name="android.support.customtabs.trusted.DISPLAY_MODE"
                 android:value="sticky-immersive" />
+            <% } else if (display === 'minimal-ui') { %>
+            <meta-data android:name="android.support.customtabs.trusted.DISPLAY_MODE"
+                android:value="minimal-ui" />
+            <% } else if (display === 'browser') { %>
+            <meta-data android:name="android.support.customtabs.trusted.DISPLAY_MODE"
+                android:value="browser" />
             <% } %>
 
             <meta-data android:name="android.support.customtabs.trusted.SCREEN_ORIENTATION"